[5.x] Fix conflict between TypeHintSniff and Slevomat null position sniff#429
Merged
dereuromark merged 1 commit into5.xfrom Mar 14, 2026
Merged
Conversation
This fixes the conflict where CakePHP's TypeHintSniff expects void to be last in union types (e.g., int|null|void), but Slevomat's nullPosition=last enforced null as last position (expecting int|void|null). Backport of 6.x fix. Fixes #426
ADmad
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullPosition="last"property fromDNFTypeHintFormatsniffThis fixes the conflict where CakePHP's
TypeHintSniffexpectsvoidto be last in union types (e.g.,int|null|void), but Slevomat'snullPosition="last"enforcednullas last position (expectingint|void|null).Backport of #427 for 5.x branch.
Fixes #426