test: update onboarding tests to support v3 feature flag #26919
+66
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the onboarding E2E tests to conditionally run either the V1 or V3 onboarding flow based on the
onboarding-v3feature flag status. This addresses the test failures in #26865 where enabling the onboarding-v3 feature flag globally causes the existing V1 tests to fail.Summary of Changes
testOnboardingtotestOnboardingV1and added feature flag check to skip when V3 is enabledtestOnboardingV3function that tests the new onboarding flow (plan selection → personal settings → calendar)Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
onboarding-v3feature flag disabled - V1 tests should run, V3 tests should skiponboarding-v3feature flag enabled - V3 tests should run, V1 tests should skipHuman Review Checklist
page.getByText("Personal"),page.getByLabel("Your name"),page.getByRole("button", { name: "Skip for now" })) match the actual UI elements - these were inferred from source code reviewfeatures.get("onboarding-v3")works correctly in CI environmentdata-testidattributes, so tests rely on text content/ARIA labels which may be more fragileLink to Devin run: https://app.devin.ai/sessions/0bea3e60c75c498a8708733551122a52
Requested by: @sean-brydon