chore: upgrade example app to Expo SDK 54 and align core dependencies#4942
Open
azizbecha wants to merge 4 commits into
Open
chore: upgrade example app to Expo SDK 54 and align core dependencies#4942azizbecha wants to merge 4 commits into
azizbecha wants to merge 4 commits into
Conversation
- example: expo ~54.0.34, react-native 0.81.5, expo-* patch bumps, babel-preset-expo ~54.0.10 - core: react-dom 19.1.0, react-test-renderer 19.1.0, react-native-safe-area-context ~5.6.0, @react-native/babel-preset ^0.81.5 - regenerate yarn.lock
Drop "privacy" and "packagerOpts" — both removed/ignored in modern Expo SDKs and flagged during the SDK 54 upgrade.
StyleSheet.absoluteFill is an opaque registered-style id, not an object, so spreading it into a StyleSheet.create() block fails type-checking (TS2698) under the react-native 0.81 type definitions. Use absoluteFillObject for the spread sites.
The app was upgraded to SDK 54 but `runtimeVersion` was still pinned to `exposdk:52.0.0`. Switch to the `sdkVersion` policy so the runtime version tracks the installed Expo SDK automatically and matches Expo Go / EAS Update.
|
Hey @azizbecha, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The example app was pinned to Expo SDK 52. This bumps it to Expo SDK 54 and
aligns the root dev dependencies (
react,react-dom,react-native,react-native-safe-area-context,@react-native/babel-preset,react-test-renderer) with the versions that SDK 54 ships, so the example appand the library build/test against a consistent toolchain.
Also includes some cleanup that came up along the way:
app.jsonfields (privacy,packagerOpts).runtimeVersionfrom the hardcodedexposdk:52.0.0to the{ "policy": "sdkVersion" }policy.StyleSheet.absoluteFill(a style array) withStyleSheet.absoluteFillObjectwhere it was being spread into aStyleSheet.createobject — spreading the array form is incorrect and theobject form is what's intended.
Related issue
N/A
Test plan
yarn lint,yarn typescript,yarn testpass.ActivityIndicator, BottomNavigation, FABGroup, Menu, Modal and
TouchableRipple still render/layout correctly.