Remove aproxy installation and add proxy support in workload#185
Remove aproxy installation and add proxy support in workload#185swetha1654 merged 41 commits intomainfrom
Conversation
yanksyoon
left a comment
There was a problem hiding this comment.
Would proxy configuration be required to be passed into network calls? Thanks :D
|
@yanksyoon I've opened a new pull request, #188, to work on those changes. Once the pull request is ready, I'll request review from you. |
cbartz
left a comment
There was a problem hiding this comment.
TY @swetha1654 ! I think what is missing is to add the proxy env vars also to the charm related network calls, like pipx or apt . The integration test is currently working because it runs on a runner that uses aproxy on the host, which forwards all traffic to a proxy. You could modify the integration test by adding a call sudo nft delete chain ip aproxy prerouting to remove routing to the aproxy on the host. I assume the tests will fail in that case.
* chore(deps): update dependency openstacksdk to v4.9.0 * lint * fix bandit warnings * lint app * fix bandit in app * fix(tests): revert integration test secrets to hardcoded values with nosec The integration test commands.py greps for specific strings (SHOULD_EXIST, SHOULD_NOT_EXIST) to verify secret handling. Random tokens broke these checks. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(build): resolve PyYAML/Cython source build failure Pin wheel>=0.45 to fix incompatibility with setuptools 80.x in charmcraft's isolated build environments. Add build packages (cython3, libyaml-dev, python3-dev) needed for PyYAML source compilation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com>
Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat: otel-collector snap * chore: application bump related changes * fix: call installation func
cbartz
left a comment
There was a problem hiding this comment.
TY! Two comments related to passing over the whole env. Otherwise looks great!
Applicable spec:
Overview
Remove aproxy installation in the charm and inject proxy values from the model config into the workload process.
Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
urgent,trivial,senior-review-required,documentation)app/pyproject.toml