Skip to content

Remove aproxy installation and add proxy support in workload#185

Merged
swetha1654 merged 41 commits intomainfrom
ISD-3652-aproxy2
Feb 17, 2026
Merged

Remove aproxy installation and add proxy support in workload#185
swetha1654 merged 41 commits intomainfrom
ISD-3652-aproxy2

Conversation

@swetha1654
Copy link
Contributor

@swetha1654 swetha1654 commented Jan 20, 2026

Applicable spec:

Overview

Remove aproxy installation in the charm and inject proxy values from the model config into the workload process.

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@swetha1654 swetha1654 marked this pull request as ready for review January 20, 2026 11:24
Copy link
Member

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would proxy configuration be required to be passed into network calls? Thanks :D

Copy link
Contributor

Copilot AI commented Jan 21, 2026

@yanksyoon I've opened a new pull request, #188, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Collaborator

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY @swetha1654 ! I think what is missing is to add the proxy env vars also to the charm related network calls, like pipx or apt . The integration test is currently working because it runs on a runner that uses aproxy on the host, which forwards all traffic to a proxy. You could modify the integration test by adding a call sudo nft delete chain ip aproxy prerouting to remove routing to the aproxy on the host. I assume the tests will fail in that case.

@swetha1654 swetha1654 closed this Jan 27, 2026
@swetha1654 swetha1654 reopened this Jan 27, 2026
renovate bot and others added 3 commits January 27, 2026 08:21
* chore(deps): update dependency openstacksdk to v4.9.0

* lint

* fix bandit warnings

* lint app

* fix bandit in app

* fix(tests): revert integration test secrets to hardcoded values with nosec

The integration test commands.py greps for specific strings (SHOULD_EXIST,
SHOULD_NOT_EXIST) to verify secret handling. Random tokens broke these checks.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(build): resolve PyYAML/Cython source build failure

Pin wheel>=0.45 to fix incompatibility with setuptools 80.x in
charmcraft's isolated build environments. Add build packages
(cython3, libyaml-dev, python3-dev) needed for PyYAML source
compilation.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com>
swetha1654 and others added 4 commits January 27, 2026 08:23
Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com>
Copy link
Collaborator

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY! Two comments related to passing over the whole env. Otherwise looks great!

@swetha1654 swetha1654 requested a review from cbartz February 17, 2026 07:15
@swetha1654 swetha1654 merged commit 88390f4 into main Feb 17, 2026
49 of 51 checks passed
@swetha1654 swetha1654 deleted the ISD-3652-aproxy2 branch February 17, 2026 10:00
@swetha1654 swetha1654 mentioned this pull request Feb 17, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants