Skip to content

resubmitting #870#892

Open
henrydingliu wants to merge 2 commits into
mainfrom
#869_new_path
Open

resubmitting #870#892
henrydingliu wants to merge 2 commits into
mainfrom
#869_new_path

Conversation

@henrydingliu
Copy link
Copy Markdown
Collaborator

@henrydingliu henrydingliu commented May 31, 2026

Summary of Changes

adding earned premium data for friedland auto bi dataset
adding earned premium to new _manifest.py source of truth
original work by @kennethshsu; resubmitting due to premature merging of new sample_data loading pattern by @henrydingliu

Related GitHub Issue(s)

#869

Additional Context for Reviewers

follows newly established pattern for adding new columns

  • I passed tests remotely for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Low Risk
Bundled sample CSV and manifest metadata only; no runtime logic, auth, or API behavior changes.

Overview
Adds Earned Premium as a third measure on the bundled friedland_auto_bi_insurer sample so load_sample exposes it alongside paid and reported claims.

The CSV gains an Earned Premium column with accident-year-level amounts (e.g. 24M for 2000, 18M for 2001), repeated on each calendar-year row for that accident year. _manifest.py registers the new column in columns, matching the manifest-driven sample loading pattern used elsewhere in the library.

Reviewed by Cursor Bugbot for commit 1984eff. Bugbot is set up for automated code reviews on this repo. Configure here.

@henrydingliu
Copy link
Copy Markdown
Collaborator Author

@kennethshsu once again, my apologies. please review at your convenience

@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.90%. Comparing base (8a9a46e) to head (1984eff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #892   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files          87       87           
  Lines        4932     4932           
  Branches      624      624           
=======================================
  Hits         4286     4286           
  Misses        456      456           
  Partials      190      190           
Flag Coverage Δ
unittests 86.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant