resubmitting #870#892
Open
henrydingliu wants to merge 2 commits into
Open
Conversation
updated premium data based on work completed by @kennethshsu
Collaborator
Author
|
@kennethshsu once again, my apologies. please review at your convenience |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
=======================================
Coverage 86.90% 86.90%
=======================================
Files 87 87
Lines 4932 4932
Branches 624 624
=======================================
Hits 4286 4286
Misses 456 456
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
adding earned premium data for friedland auto bi dataset
adding earned premium to new _manifest.py source of truth
original work by @kennethshsu; resubmitting due to premature merging of new sample_data loading pattern by @henrydingliu
Related GitHub Issue(s)
#869
Additional Context for Reviewers
follows newly established pattern for adding new columns
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Low Risk
Bundled sample CSV and manifest metadata only; no runtime logic, auth, or API behavior changes.
Overview
Adds Earned Premium as a third measure on the bundled
friedland_auto_bi_insurersample soload_sampleexposes it alongside paid and reported claims.The CSV gains an Earned Premium column with accident-year-level amounts (e.g. 24M for 2000, 18M for 2001), repeated on each calendar-year row for that accident year.
_manifest.pyregisters the new column incolumns, matching the manifest-driven sample loading pattern used elsewhere in the library.Reviewed by Cursor Bugbot for commit 1984eff. Bugbot is set up for automated code reviews on this repo. Configure here.