This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Add gRPC server interceptor#123
Open
south37 wants to merge 2 commits intocensus-instrumentation:masterfrom
Open
Add gRPC server interceptor#123south37 wants to merge 2 commits intocensus-instrumentation:masterfrom
south37 wants to merge 2 commits intocensus-instrumentation:masterfrom
Conversation
south37
commented
Jan 20, 2020
| span.put_attribute "http.status_code", to_http_status(exception) | ||
| end | ||
|
|
||
| # rubocop:disable Metrics/MethodLength |
Author
There was a problem hiding this comment.
Here, I disabled Metrics/MethodLength and Metrics/CyclomaticComplexity because #to_http_status is inherently complex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
I want to use opencensus with gRPC server.
Discussion on this topic was found in #79 , but I couldn't find any implementation.
WHAT
I implemented
GrpcServerInterceptor. By using this, we can send spans to each exporter.In this implementation, span names and span statuses are set according to the following document.
cf. https://github.com/census-instrumentation/opencensus-specs/blob/master/trace/gRPC.md
Each span also has some useful attributes (e.g. http.path, http.method, http.user_agent, etc.).
So far I have only implemented the server interceptor, but in the future, I will also implement the client interceptor.