ENT-14139: Fixed cf-agent SIGABRT on SIGTERM during early policy validation#6140
Merged
Conversation
When SIGTERM arrives before `ThisAgentInit()`, the signal handler calls `TerminateCustomPromises()` while `custom_modules` is still `NULL`, causing an assert to be triggered in `MapIteratorInit()`. Ticket: ENT-14139 Changelog: Title Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
added
the
cherry-pick?
Contributor
Author
|
@cf-bottom Jenkins please :) |
craigcomstock
approved these changes
May 26, 2026
Contributor
craigcomstock
left a comment
craigcomstock
left a comment
There was a problem hiding this comment.
The change looks smart and right.
I wonder about how this situation happens or how it could be reproduced. I think that would be a good addition to the commit message.
Contributor
Author
@craigcomstock, I feel like the commit message already says this. Maybe it could be stated even clearer. It happens if you kill the agent very early. |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13851/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13851/ |
larsewi
removed
the
cherry-pick?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When SIGTERM arrives before
ThisAgentInit(), the signal handler callsTerminateCustomPromises()whilecustom_modulesis stillNULL, causing an assert to be triggered inMapIteratorInit().Ticket: ENT-14139
Backported to: