Skip to content

ENT-7923: Removed cfe_internal_update_health_failures bundle#3159

Open
larsewi wants to merge 1 commit into
cfengine:masterfrom
larsewi:fix-update-health-failures-race
Open

ENT-7923: Removed cfe_internal_update_health_failures bundle#3159
larsewi wants to merge 1 commit into
cfengine:masterfrom
larsewi:fix-update-health-failures-race

Conversation

@larsewi
Copy link
Copy Markdown
Contributor

@larsewi larsewi commented May 21, 2026 •
edited
Loading

cf-reactor now schedules the update_health_failures CLI task on its own
1-minute timer. The policy bundle is no longer needed.

Together with:

@larsewi
Copy link
Copy Markdown
Contributor Author

larsewi commented May 21, 2026

@cf-bottom Jenkins please :)

nickanderson
nickanderson reviewed May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@nickanderson nickanderson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love making the class namespace scoped.

Comment thread cfe_internal/enterprise/CFE_hub_specific.cf Outdated
@larsewi larsewi force-pushed the fix-update-health-failures-race branch 2 times, most recently from bfb3df0 to be3c6af Compare May 22, 2026 12:14
@larsewi larsewi changed the title ENT-7923: Skip enterprise maintenance PHP cli_tasks while cf-apache is restarting ENT-7923: Removed cfe_internal_update_health_failures bundle May 22, 2026
@cfengine cfengine deleted a comment from cf-bottom May 22, 2026
@cf-bottom
Copy link
Copy Markdown

cf-bottom commented May 22, 2026

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/13838/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13838/

@larsewi larsewi marked this pull request as ready for review May 22, 2026 13:54
craigcomstock
craigcomstock reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the case for all supported branches?

@larsewi
Copy link
Copy Markdown
Contributor Author

larsewi commented May 26, 2026

Is this the case for all supported branches?

@craigcomstock, you mean the CI failure? Yes, It looks like it was first reported for CFEngine 3.18

@nickanderson
Copy link
Copy Markdown
Member

nickanderson commented May 26, 2026

Is this the case for all supported branches?

@craigcomstock, you mean the CI failure? Yes, It looks like it was first reported for CFEngine 3.18

When does cf-reactor begin to take over this function?

Isn't the bundle still needed until there are no supported versions where cf-reactor is not yet updating the table e.g. while binaries are last version but have started running the next policy version in preparation for upgrade at some point.

@larsewi larsewi force-pushed the fix-update-health-failures-race branch from be3c6af to 84a717d Compare May 27, 2026 07:55
@larsewi
Removed cfe_internal_update_health_failures bundle
4359534 
cf-reactor now schedules the update_health_failures CLI task on its own
1-minute timer. The policy bundle is no longer needed for CFEngine
version 3.28 or later.

Ticket: ENT-7923
Changelog: Moved update_health_failures CLI task from policy to cf-reactor
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi larsewi force-pushed the fix-update-health-failures-race branch from 84a717d to 4359534 Compare May 27, 2026 07:57
@larsewi larsewi requested a review from craigcomstock May 27, 2026 07:58
@larsewi
Copy link
Copy Markdown
Contributor Author

larsewi commented May 27, 2026

Is this the case for all supported branches?

@craigcomstock, you mean the CI failure? Yes, It looks like it was first reported for CFEngine 3.18

When does cf-reactor begin to take over this function?

Isn't the bundle still needed until there are no supported versions where cf-reactor is not yet updating the table e.g. while binaries are last version but have started running the next policy version in preparation for upgrade at some point.

Thanks @nickanderson. Did not even think about that. Added a macro to only exclude it for versions prior to CFEngine 3.28

nickanderson
nickanderson approved these changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK maybe a comment about when to remove the bundle completely. I guess that would be the when the first LTS release after 3.28 goes EOL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickanderson nickanderson nickanderson approved these changes

@craigcomstock craigcomstock Awaiting requested review from craigcomstock

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@larsewi @cf-bottom @nickanderson @craigcomstock