Preserve spacing for vertical imported group wrappers#227
Open
homeboy-ci[bot] wants to merge 1 commit into
Open
Preserve spacing for vertical imported group wrappers#227homeboy-ci[bot] wants to merge 1 commit into
homeboy-ci[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.wp-block-group.is-vertical) do not reintroduce block gap spacing that was not present in the source static HTML.Evidence
chubes4/wp-site-generator#24225882026544visual-parity-issue-240-wickstead-refill-worksissue-240-wickstead-refill-works25.01%mismatch with dimension mismatch (source=1280x4840,imported=1280x4884).screenshot region 32,192 1216x3328; sourcemain#main, importedmain#wp--skip-link--target.entry-content.wp-block-post-content.is-layout-flow.section#top.wp-block-group.hero.is-verticalwith a taller rect (1180x1311) than the sourcesection#top.hero(1180x1064), shifting downstream regions..wp-block-group.section-heading.is-layout-flow,.wp-block-group.table-wrap.is-layout-flow, and.wp-block-group.caution-label.is-layout-flow.Patch path
static-site-importerbecause the repair is in generated theme CSS/layout bridging, not the source HTML-to-block conversion registry.Static_Site_Importer_Theme_Generator::imported_group_layout_gap_bridge_css()already neutralizes imported.wp-block-group.is-layout-flowmargins and.is-layout-flexgaps..wp-block-group.is-verticalin the same generated CSS bridge so WordPress vertical group layout gap does not add spacing on top of source-authored CSS.Tests
tests/StaticSiteImporterFixtureTest.php/tests/smoke-editor-style-support.php, which already asserts this bridge is emitted for layout-flow/flex generated styles. This patch is the same bridge extension for the observed vertical wrapper class.AI assistance disclosure
Prepared by an AI agent in response to the SSI visual parity finding packet.