Fix error when executing insert on secondary worker node #8419
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
templarzq
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Author
@microsoft-github-policy-service agree |
Added check for if its running in recovery progress before returning task placement status.
add private Node pointer null check
add task type check
remove vacuum task check
Contributor
|
Thanks for this PR, can you add a regress test with the problem ? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8419 +/- ##
==========================================
- Coverage 88.80% 83.52% -5.28%
==========================================
Files 287 287
Lines 63236 62988 -248
Branches 7927 7878 -49
==========================================
- Hits 56155 52613 -3542
- Misses 4750 7725 +2975
- Partials 2331 2650 +319 🚀 New features to boost your workflow:
|
colm-mchugh
reviewed
Jan 11, 2026
| Node *privateNode = (Node *) linitial(customScan->custom_private); | ||
| //shoud check privateNode is null ptr | ||
| if (privateNode == NULL){ | ||
| return false; |
Contributor
There was a problem hiding this comment.
It may be preferable to throw an error here, given that custom_private is unconditionally set in FinalizePlan(). If the list contains a NULL it indicates something has gone wrong before this point. Suggest debugging FinalizePlan() from the point where custom_private is set, and try to determine if the CustomScan node is initialized correctly there and where it changes state to result in the problem here.
Author
|
it seems that we need some new test case to pass the code coverage test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8426
Citus version: master
DESCRIPTION:
set citus.writable_standby_coordinator ="on", when insert values on secondary work node, if the values belong to local shard tables, the plan will run on local node ,this will trigger an error.
this pull request will fix this error, route the plan to correct primary node to execute the insert sql.