test: add context manager tests for __enter__ behavior#274
Merged
Conversation
fix: update 'with' macro to bind return value of __enter__ correctly
Contributor
|
Good catch. Technically this is a backwards breaking change but I sincerely doubt anyone is explicitly expecting the bound/return value to always be Traveling right now for conference stuff but I will pull it and check it when I can. Thanks for the contribution! |
Contributor
|
@lidorcg overall looks good to me. Tested locally and working great. Would prefer you revert the unrelated formatting changes and do that in separate PR. Excellent contribution, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: update 'with' macro to bind return value of
__enter__correctly#273