Skip to content

Wait to unsubscribe in csharp-testsuite until required ops have finished #5135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshua-spacetime wants to merge 1 commit into from
Closed

Wait to unsubscribe in csharp-testsuite until required ops have finished #5135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions sdks/csharp/examples~/regression-tests/client/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
DbConnection db = null!;
uint waiting = 0;
var runComplete = false;
var mainPhaseScheduled = false;
var mainUnsubscribeStarted = false;
SubscriptionHandle? mainHandle = null;
uint testEventInsertCount = 0;
long viewPkIdCounter = DateTimeOffset.UtcNow.ToUnixTimeMilliseconds() * 10;
Expand Down Expand Up @@ -1621,10 +1623,28 @@ ProcedureCallbackResult<Result<ReturnStruct, string>> result
}
);

// The unsubscribe phase clears the subscribed cache.
// Start it only after the reducer and procedure callbacks above
// have finished validating rows in that cache.
mainPhaseScheduled = true;
}

void StartMainUnsubscribe()
{
if (mainUnsubscribeStarted)
{
return;
}
mainUnsubscribeStarted = true;

var handle =
mainHandle
?? throw new InvalidOperationException("Main subscription handle was not initialised.");

// Now unsubscribe and check that the unsubscribing is actually applied.
Log.Debug("Calling Unsubscribe");
waiting++;
mainHandle?.UnsubscribeThen(
handle.UnsubscribeThen(
(ctx) =>
{
Log.Debug("Received Unsubscribe");
Expand All @@ -1638,6 +1658,18 @@ ProcedureCallbackResult<Result<ReturnStruct, string>> result
RegressionTestHarness.RegisterUnhandledExceptionExitHandler();
db = RegressionTestHarness.ConnectToDatabase(HOST, DBNAME, OnConnected);
const int TIMEOUT = 20; // seconds;
RegressionTestHarness.FrameTickUntilComplete(db, () => runComplete && waiting == 0, TIMEOUT);
RegressionTestHarness.FrameTickUntilComplete(
db,
() =>
{
if (mainPhaseScheduled && !mainUnsubscribeStarted && waiting == 0)
{
StartMainUnsubscribe();
}

return runComplete && waiting == 0;
},
TIMEOUT
);
Log.Info("Success");
Environment.Exit(0);
Loading