Skip to content

ci: keep provider cert when setting up director#213

Merged
KauzClay merged 1 commit into
masterfrom
fix-pipeline
May 8, 2026
Merged

ci: keep provider cert when setting up director#213
KauzClay merged 1 commit into
masterfrom
fix-pipeline

Conversation

@KauzClay
Copy link
Copy Markdown
Contributor

@KauzClay KauzClay commented May 8, 2026

(already flown)

I believe as part of cloudfoundry/bosh-cli#725 (bosh-cli v7.10.4), the cert handling changed in the CLI

from what AI tells me, in the CLI code now, when cloud_provider.cert is absent (because remove-provider-cert.yml removes it), the certPool is nil → the client falls back to verifying against system roots. The BOSH bootstrap agent's cert is signed by the private default_ca, which is not in the system root store → x509: certificate signed by unknown authority.

this shows up like this:
https://bosh.ci.cloudfoundry.org/teams/main/pipelines/bosh-aws-cpi/jobs/bats/builds/223
https://bosh.ci.cloudfoundry.org/teams/main/pipelines/bosh-aws-cpi/jobs/end-2-end/builds/146

I believe as part of 2f355267db4c370eb5e7d0a9426220347cced9df (bosh-cli v7.10.4), the cert handling changed in the CLI

from what AI tells me, in the CLI code now, when cloud_provider.cert is absent
(because remove-provider-cert.yml removes it), the certPool is nil → the client
falls back to verifying against system roots. The BOSH bootstrap agent's cert
is signed by the private default_ca, which is not in the system root store →
x509: certificate signed by unknown authority.

with this opsfile present, we'd be falling back to default system certs, which wouldn't include what bosh uses

ai-assisted=yes
[TNZ-95674] AWS CPI fails to apply mandatory tags at creation time for multiple AWS resources
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 8, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: KauzClay / name: Clay Kauzlaric (38f07e6)

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 8, 2026

Review Change Stack

Walkthrough

This pull request updates the CI pipeline configuration in ci/pipeline.yml by modifying the optional operation files used during the prepare-director step in two pipeline jobs. The bats job now includes health monitor removal and external IP registry operations instead of provider certificate removal. The end-2-end job replaces provider certificate removal with the external IP registry operation. These changes affect which BOSH operations are applied when preparing the director for each job's testing scenario.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: keeping the provider certificate when setting up the director, which directly addresses the core issue of removing the remove-provider-cert.yml operation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly explains the certificate-handling regression introduced in bosh-cli v7.10.4 and directly relates to the changeset that removes remove-provider-cert.yml operations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-pipeline

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KauzClay KauzClay merged commit d11476b into master May 8, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants