Allow either_consistent for HashSyntax#4949
Merged
sethboyles merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Mar 20, 2026
Changes in cloud_controller_ng:
- Allow either_consistent for HashSyntax
PR: cloudfoundry/cloud_controller_ng#4949
Author: Seth Boyles <seth.boyles@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having HashSyntax as
consistentautocorrects hashes or method calls likeAppModel.where(space: space)toAppModel.where(space:).IMO this is is not always the clearest way of instantiating a hash or calling a method and should be left to developer discretion to omit the variable.
either_consistentallows either style, but still enforces the style within a single hash (e.g. you can't have{space: space, app: })cc @tcdowney