Skip to content

[go-migration] Fix replacing of launcher class for spring-boot apps, refactor spring-boot container #1209

Merged
ramonskie merged 2 commits intocloudfoundry:feature/go-migrationfrom
kiril-keranov:patch-22
Mar 16, 2026
Merged

[go-migration] Fix replacing of launcher class for spring-boot apps, refactor spring-boot container #1209
ramonskie merged 2 commits intocloudfoundry:feature/go-migrationfrom
kiril-keranov:patch-22

Conversation

@kiril-keranov
Copy link
Contributor

@kiril-keranov kiril-keranov commented Mar 13, 2026

  • Fix replacing of the specified Spring-boot launcher class in the corresponding application manifest to always use JarLauncher for spring-boot exploded jars. For example if another launcher is specified in the app manifest like Main-Class: org.springframework.boot.loader.launch.PropertiesLauncher it will be replaced with org.springframework.boot.loader.launch.JarLauncher for spring-boot 3.x apps or org.springframework.boot.loader.JarLauncher for spring-boot 2.x apps when building the start command for this application. Seems this is due to some AI generation issue as the current buildpack comprises no such logic.
  • Also some code refactoring is applied in the spring-boot container to prevent code duplication.
  • Fix failing tests with regard to -Xbootclasspath/a: removal with previous PR.

Copy link
Contributor

@ramonskie ramonskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ramonskie ramonskie merged commit 67a8514 into cloudfoundry:feature/go-migration Mar 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants