fix(metrics): announce sidecar injection capability#776
Merged
mnencia merged 1 commit intocloudnative-pg:mainfrom Mar 31, 2026
Merged
fix(metrics): announce sidecar injection capability#776mnencia merged 1 commit intocloudnative-pg:mainfrom
mnencia merged 1 commit intocloudnative-pg:mainfrom
Conversation
dosubot
bot
added
size:XS
kruton
force-pushed
the
injection-bug
branch
2 times, most recently
from
21b45e9 to
c433889
Compare
GabriFedi97
approved these changes
Mar 30, 2026
Member
|
proposed commit: fix(identity): add sidecar injection capability to operator The operator plugin was not advertising the TYPE_INSTANCE_SIDECAR_INJECTION |
armru
approved these changes
Mar 30, 2026
mnencia
approved these changes
Mar 31, 2026
mnencia
changed the title
The operator was not announcing the TYPE_INSTANCE_SIDECAR_INJECTION capability so the CNPG operator was not considering the plugin enabled. However, this bug was masked if you had set `isWALArchiver` to `true` in your config, the backward compatibility code was marking the plugin as enabled as a side-effect. Signed-off-by: Kenny Root <kenny@the-b.org>
mnencia
approved these changes
Mar 31, 2026
Member
mnencia
left a comment
mnencia
left a comment
There was a problem hiding this comment.
The fix correctly adds TYPE_INSTANCE_SIDECAR_INJECTION to the advertised plugin capabilities. This is backed by the existing OperatorLifecycleServer implementation which already handles pod mutation and sidecar injection via lifecycle hooks. The missing capability was preventing the CNPG operator from considering the plugin enabled, which in turn broke metrics collection for users with isWALArchiver: false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operator was not announcing the
TYPE_INSTANCE_SIDECAR_INJECTIONcapability, so the CNPG operator did not consider the plugin enabled for instance pods. As a result, the instance manager never queried the plugin's metrics endpoint, and the newbarman_cloud_cloudnative_pg_io_*metrics were missing entirely.This bug was masked when
isWALArchiverwas set totruein the plugin configuration, because the backward compatibility code in CNPG would mark the plugin as enabled as a side-effect. Users withisWALArchiver: false(or omitted) never saw the new metrics.The fix adds
TYPE_INSTANCE_SIDECAR_INJECTIONtoGetPluginCapabilities(), which is already backed by the existingOperatorLifecycleServerimplementation that handles pod mutation and sidecar injection via lifecycle hooks.Fixes #682