fix: handle HTTP/2 responses without a reason phrase in CURLRequest#10050
Merged
michalsn merged 4 commits intocodeigniter4:developfrom Mar 19, 2026
Merged
fix: handle HTTP/2 responses without a reason phrase in CURLRequest#10050michalsn merged 4 commits intocodeigniter4:developfrom
michalsn merged 4 commits intocodeigniter4:developfrom
Conversation
michalsn
added
the
bug
paulbalandan
approved these changes
Mar 19, 2026
neznaika0
suggested changes
Mar 19, 2026
Member
Author
|
Thanks for the reviews! |
neznaika0
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes PHPStan errors, exposed here: https://github.com/codeigniter4/CodeIgniter4/actions/runs/23252730600/job/67598946599?pr=10049
Additionally, it fixes an issue in
CURLRequestwhere HTTP/2 status lines without a reason phrase (e.g.HTTP/2 200) were not parsed correctly. This format is valid according to RFC 7540 and is used by curl for HTTP/2 and HTTP/3 responses.The regex has been updated to make the reason phrase optional. The fallback value was also corrected from
?? nullto?? ''to match the string type expectation.Checklist: