feat: make rulesengine stricter #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniy-scherbina
force-pushed
the
yevhenii/strict-rules-engine
branch
from
069a9f9 to
4c55fbf
Compare
evgeniy-scherbina
force-pushed
the
yevhenii/strict-rules-engine
branch
from
ecae77a to
0db0440
Compare
f0ssel
approved these changes
Jan 15, 2026
Collaborator
f0ssel
left a comment
f0ssel
left a comment
There was a problem hiding this comment.
All for stricter syntax here
evgeniy-scherbina
force-pushed
the
yevhenii/strict-rules-engine
branch
from
e4f7585 to
7d5a99a
Compare
evgeniy-scherbina
force-pushed
the
yevhenii/strict-rules-engine
branch
from
7d5a99a to
7af16a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #143
Implement Stricter Domain Matching in Rules Engine
Summary
Implements stricter domain matching to prevent automatic subdomain matching, improving security by requiring explicit patterns.
Behavior Changes
Before:
domain=github.com→ matchesgithub.comand all subdomains (e.g.,api.github.com,fake.github.com)After:
domain=github.com→ matches ONLYgithub.com(exact match)domain=*.github.com→ matches ONLY subdomains (not base domain)domain=github.com,domain=*.github.comSecurity Impact
Prevents accidental matching of malicious subdomains (e.g.,
fake.github.commatchinggithub.comrule).Migration
Update existing rules that rely on automatic subdomain matching: