test(proxy): integration tests for session correlation audit and header agreement by SasSwart · Pull Request #199 · coder/boundary

SasSwart · 2026-05-01T12:36:26Z

PR Map

feat(audit): session ID generation, sequence counter, and BoundaryLog wiring #196
feat(config): session correlation header injection configuration #197
feat(proxy): inject session ID and sequence number headers on matching requests #198
👉🏼 test(proxy): integration tests for session correlation audit and header agreement #199

Integration tests for session correlation, requested during review of #196. The existing unit tests in #198 verify header injection and audit capture independently; these tests verify both sides together across realistic multi-request scenarios.

Depends on #201.

Changes

proxy/proxy_session_correlation_integration_test.go: New test file with 8 integration tests and supporting helpers.

Test scenarios

Test	What it verifies
`LLMRequestAuditAndHeadersAgree`	Audit sequence number == forwarded header value on inject-target requests
`NonLLMRequestAuditedWithoutHeaders`	Allowed non-inject-target requests are audited but carry no correlation headers
`DeniedRequestAuditedNeverForwarded`	Denied requests consume a sequence number but are never forwarded
`MixedRequestsSequenceOrdering`	Interleaved LLM, non-LLM, and denied requests advance the counter monotonically
`SequenceGapRevealsAgenticLoop`	Gap between two LLM sequence numbers equals the count of intermediate tool-use requests
`SpoofedHeadersOverwrittenWithCorrectSequence`	Client-supplied headers are replaced; audit event still agrees with header
`DisabledCorrelationNoHeadersNoPreallocatedSequence`	Disabled correlation means no headers and no pre-allocated sequence number
`ConcurrentRequestsUniqueSequenceNumbers`	10 concurrent requests each get a unique, dense sequence number

Test helpers

multiRequestCapturingBackend: like the existing headerCapturingBackend but records headers from every request (not just the last), needed for multi-request scenarios.
sessionCorrelationIntegrationSetup: shared setup that wires a proxy with two httptest backends (LLM inject target + non-LLM), a capturingAuditor, and a shared SequenceCounter.

Note

This PR was authored by Coder Agents.

SasSwart

A few things to address before I can request external review.

SasSwart · 2026-05-13T11:41:22Z

+// integration test: the proxy, auditor, backend(s), and sequence
+// counter. Tests build one via newSessionCorrelationIntegrationSetup
+// and tear it down with stop.
+type sessionCorrelationIntegrationSetup struct {


not a fan of this name. What is a setup?

SasSwart · 2026-05-13T11:44:54Z

+// counter. Tests build one via newSessionCorrelationIntegrationSetup
+// and tear it down with stop.
+type sessionCorrelationIntegrationSetup struct {
+	pt           *ProxyTest


Feels like a smell that this wraps ProxyTest.

SasSwart · 2026-05-13T11:55:56Z

+	events := aud.getRequests()
+	require.Len(t, events, 1)
+	require.False(t, events[0].Allowed)
+	require.NotNil(t, events[0].SequenceNumber)
+	assert.Equal(t, int32(0), events[0].SequenceNumber)


We do this set of assertions in almost every test. do we need a helper? would that shorten the tests?

SasSwart · 2026-05-13T12:04:11Z

+			InjectTargets: []config.InjectTarget{{Domain: llmURL.Hostname()}},
+		}),
+		WithSessionID("should-not-appear"),
+		// Explicitly do NOT set WithSequenceCounter; seqCounter is nil.


Don't we still set seqCounter even when correlation is disabled? This might not be a valid way to test.

…er agreement Add integration tests that verify the core invariants of session correlation across the proxy, auditor, and forwarded request headers working together. These tests fill the gap identified during review of the session correlation PR stack (#196, #197, #198) where unit tests verified each component in isolation but did not verify them in concert. New test file: proxy/proxy_session_correlation_integration_test.go Tests added: - LLMRequestAuditAndHeadersAgree: audit sequence number matches the forwarded header value on inject-target requests. - NonLLMRequestAuditedWithoutHeaders: allowed non-inject-target requests are audited but carry no correlation headers. - DeniedRequestAuditedNeverForwarded: denied requests consume a sequence number but are never forwarded. - MixedRequestsSequenceOrdering: interleaved LLM, non-LLM, and denied requests all advance the counter monotonically. - SequenceGapRevealsAgenticLoop: gap between two LLM sequence numbers precisely equals intermediate tool-use requests. - SpoofedHeadersOverwrittenWithCorrectSequence: client-supplied headers are replaced and the audit event still agrees. - DisabledCorrelationNoHeadersNoPreallocatedSequence: disabled correlation means no headers and no pre-allocated sequence. - ConcurrentRequestsUniqueSequenceNumbers: concurrent requests each get a unique, dense sequence number.

…ames and sequence number type Modified integration tests to reflect changes in session correlation header names and updated the sequence number type from uint64 to int32. Adjusted assertions in tests to ensure consistency with the new data types and header configurations, enhancing clarity and correctness in the test suite.

- Remove '// ---------- Integration Tests ----------' section separator - Rename 'hdr'/'Hdr' variables to 'header'/'Header' for clarity - Rename 'llm'/'llmBackend' to 'injectBackend'/'inject'/'backend' to reflect the actual concept (inject target) rather than a specific use case (LLM) - Update comments to match the new naming Generated by Coder Agents

…n integration tests - Enhanced comments for clarity regarding the purpose of `injectBackend` and `otherBackend`. - Removed unnecessary comments to streamline the test code. - Adjusted formatting for consistency and readability in the `sessionCorrelationIntegrationSetup` struct. These changes aim to improve the maintainability and understanding of the integration tests related to session correlation.

- Rename sessionCorrelationIntegrationSetup to correlationTestEnv and newSessionCorrelationIntegrationSetup to newCorrelationTestEnv for brevity and clarity. - Rename TestIntegration_DisabledCorrelationNoHeadersNoPreallocatedSequence to TestIntegration_DisabledCorrelationNoHeaders. The sequence counter is a value type on the proxy server and always increments regardless of the correlation setting, so the previous name and assertions about 'no pre-allocated sequence number' were misleading. The test now focuses on what actually differs: no headers are injected. - Remove misleading 'auditor falls back to its own counter' comment. Generated by Coder Agents

PR #201 was merged to main, replacing config.InjectTarget struct with []string rule specs (rulesengine syntax). Update the integration test file to use the []string format, and sync config/, proxy/proxy.go, and other test files from main to fix the build. Generated by Coder Agents

SasSwart force-pushed the sasswart/feat-proxy-inject-session-headers branch 2 times, most recently from d8635fb to 79d6485 Compare May 7, 2026 14:33

SasSwart force-pushed the sasswart/test-session-correlation-integration branch from ae01776 to 4a1655f Compare May 7, 2026 17:21

This was referenced May 12, 2026

refactor(proxy): unify inject target matching with rulesengine #201

Merged

feat(proxy): inject session ID and sequence number headers on matching requests #198

Merged

SasSwart changed the base branch from sasswart/feat-proxy-inject-session-headers to sasswart/refactor-unify-inject-target-matching May 12, 2026 10:11

Base automatically changed from sasswart/refactor-unify-inject-target-matching to sasswart/feat-proxy-inject-session-headers May 12, 2026 12:24

Base automatically changed from sasswart/feat-proxy-inject-session-headers to main May 13, 2026 08:56

SasSwart marked this pull request as draft May 13, 2026 09:39

SasSwart commented May 13, 2026

View reviewed changes

SasSwart marked this pull request as ready for review May 13, 2026 12:14

SasSwart requested a review from dannykopping May 14, 2026 07:39

SasSwart added 7 commits May 14, 2026 10:25

make fmt

f578460

SasSwart force-pushed the sasswart/test-session-correlation-integration branch from 11b11c0 to f578460 Compare May 14, 2026 10:29

test(proxy): use Given/When/Then style comments in integration tests

a9d59ec

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(proxy): integration tests for session correlation audit and header agreement#199

test(proxy): integration tests for session correlation audit and header agreement#199
SasSwart wants to merge 8 commits into
mainfrom
sasswart/test-session-correlation-integration

SasSwart commented May 1, 2026 •

edited

Loading

Uh oh!

SasSwart left a comment

Uh oh!

Uh oh!

SasSwart May 13, 2026

Uh oh!

Uh oh!

SasSwart May 13, 2026

Uh oh!

Uh oh!

SasSwart May 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SasSwart May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

SasSwart commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Map

Changes

Test scenarios

Test helpers

Uh oh!

SasSwart left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SasSwart May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SasSwart May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SasSwart May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SasSwart May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

SasSwart commented May 1, 2026 •

edited

Loading