🤖 fix: spawn local PTY terminals on Windows #1622
Merged
+195
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibetitsmike
force-pushed
the
mike/fix-windows-pty-shell
branch
from
5e8e543 to
143b91d
Compare
ethanndickson
pushed a commit
that referenced
this pull request
Jan 15, 2026
This fixes embedded terminal creation on Windows failing with: - `Failed to spawn Local terminal: File not found:` Root cause was `PTYService` using `process.env.SHELL ?? "/bin/bash"` for *local* PTY sessions. On Windows this can be unset, invalid, or even present-but-empty (`SHELL=""`), which results in node-pty attempting to spawn an empty executable. ### What changed - Added `resolveLocalPtyShell()` to pick a sane default shell per platform. - Windows: prefer Git Bash (if available), else `pwsh` → `powershell` → `COMSPEC`/`cmd.exe` - Non-Windows: prefer non-empty `SHELL`, else `/bin/zsh` (macOS) or `/bin/bash` - `PTYService` local sessions now use the resolver and include args (e.g. `--login -i` for Git Bash). - Improved PTY spawn failures to include the attempted command/args/cwd/platform (and preserve the original error as `cause`). ### Validation - `bun test src/node/utils/main/resolveLocalPtyShell.test.ts` - `make static-check` --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: `$2.00`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes embedded terminal creation on Windows failing with:
Failed to spawn Local terminal: File not found:Root cause was
PTYServiceusingprocess.env.SHELL ?? "/bin/bash"for local PTY sessions. On Windows this can be unset, invalid, or even present-but-empty (SHELL=""), which results in node-pty attempting to spawn an empty executable.What changed
resolveLocalPtyShell()to pick a sane default shell per platform.pwsh→powershell→COMSPEC/cmd.exeSHELL, else/bin/zsh(macOS) or/bin/bashPTYServicelocal sessions now use the resolver and include args (e.g.--login -ifor Git Bash).cause).Validation
bun test src/node/utils/main/resolveLocalPtyShell.test.tsmake static-checkGenerated with
mux• Model:openai:gpt-5.2• Thinking:xhigh• Cost:$2.00