🤖 feat: add first-class link support with PR status badges #1623

ammar-agent · 2026-01-14T16:38:58Z

Summary

Add link detection and display to the workspace header, with special handling for GitHub PR links.

Features

Branch-based PR detection: Automatically detects PR for current branch via gh pr view (no URL argument)
Link extraction: Scans assistant text and tool output for URLs (shown in dropdown)
PR badge display: Shows workspace's PR as a clickable badge in the workspace header
PR status enrichment: Fetches PR state (open/merged/closed), mergeability, and draft status
Generic links dropdown: Non-PR URLs displayed in a scrollable dropdown with copy functionality

Architecture

Two separate concerns

PR detection (badge): Branch-based via gh pr view - robust, doesn't depend on chat content
Link extraction (dropdown): Scans chat for URLs - shows relevant links mentioned in conversation

PR detection flow

WorkspaceLinks mounts
  → monitorWorkspace(workspaceId)
  → gh pr view --json ...  (no URL = current branch)
  → PRStatusStore caches result
  → useWorkspacePR(workspaceId) returns PR with status

Link extraction robustness

Only scans complete text parts (triggered on tool-call-start or stream-end)
Rescans after compaction to catch URLs split across deltas
Tracks occurrence count and last-seen timestamp

Design decisions

Links derived from message history on load, not persisted to localStorage
PR badge comes from branch detection, not from chat-extracted PR links
Dropdown sorted by occurrence count (most seen first), then recency

UX Features

Copy button on each link in dropdown
Hover tooltip shows full URL + "Seen N times · Last seen X ago"
Scrollable dropdown (max 10 visible, all accessible via scroll)
PR badge shows status icons (draft, checks, mergeability)

Generated with mux • Model: ${MUX_MODEL_STRING:-unknown} • Thinking: ${MUX_THINKING_LEVEL:-unknown} • Cost: $${MUX_COSTS_USD:-unknown}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e7c7e177f1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/browser/utils/messages/StreamingMessageAggregator.ts

src/browser/components/LinksDropdown.tsx

ammar-agent · 2026-01-14T16:46:28Z

CI Status

The test failures in handleCompactCommand are pre-existing issues on main (see run 20999346497 on main which has the same failures). These tests are unrelated to the link feature changes.

Link-related tests all pass locally:

src/common/types/links.test.ts - 17 tests
src/browser/utils/messages/StreamingMessageAggregator.links.test.ts - 11 tests

ammar-agent · 2026-01-14T17:37:42Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 37a8818ebd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/browser/utils/messages/StreamingMessageAggregator.ts

ammar-agent · 2026-01-14T17:45:33Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62646e5597

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/browser/utils/messages/StreamingMessageAggregator.ts

ammar-agent · 2026-01-14T17:51:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 621b206f05

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/browser/utils/messages/StreamingMessageAggregator.ts

ammar-agent · 2026-01-14T17:59:13Z

@codex review

Add link detection and display to the workspace header: - Extract links from chat content (user messages, assistant text, tool output) - Parse GitHub PR URLs into structured data (owner, repo, number) - Show the most recent PR link as a badge in the workspace header - Fetch PR status via gh CLI (state, mergeable, merge status, draft) - Display generic links in a dropdown menu Link extraction is robust to streaming: - Only scan complete text parts (on tool-call-start or stream-end) - Use progress tracking to avoid re-scanning parts - Deduplicate links by URL Implementation details: - Links derived from message history, not persisted to localStorage - PR status cached with TTL and refreshed on focus - Single PR link tracked (lastGitHubPRLink) per review feedback

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5aaf2cb2f2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-14T22:07:40Z

src/browser/components/PRLinkBadge.tsx

+  if (mergeStateStatus === "CLEAN") return "text-success";
+  if (mergeStateStatus === "BEHIND") return "text-warning";
+
+  // Prefer check rollup when available; fall back to mergeStateStatus.
+  if (hasFailedChecks || mergeStateStatus === "UNSTABLE") return "text-danger-soft";


Respect check rollup before marking PR as clean

The badge logic returns success as soon as mergeStateStatus === "CLEAN", so any hasFailedChecks/hasPendingChecks data from statusCheckRollup is ignored. That means a PR with non‑required checks failing or still running will still show a green check/“ready” even though the rollup says otherwise. The comment says to prefer the rollup, but the ordering makes the rollup unreachable in the CLEAN/BEHIND paths. The same ordering issue exists in StatusIcon below, so both color and icon can be misleading for optional checks.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-01-14T22:07:40Z

src/common/types/links.ts

+    .filter((url) => {
+      // Filter out malformed URLs that are too short or don't have a domain
+      try {
+        const parsed = new URL(url);
+        return parsed.hostname.includes(".");


Allow localhost/intranet URLs in link extraction

The hostname filter parsed.hostname.includes(".") drops valid URLs like http://localhost:3000 or short intranet hosts (http://devbox). Those are common in tool output (local preview servers, internal dashboards), so they will never appear in the links dropdown even though they are valid URLs. This makes the link extraction feature silently miss a frequent class of links.

Useful? React with 👍 / 👎.

## Summary Add link detection and display to the workspace header, with special handling for GitHub PR links. ## Features - **Branch-based PR detection**: Automatically detects PR for current branch via `gh pr view` (no URL argument) - **Link extraction**: Scans assistant text and tool output for URLs (shown in dropdown) - **PR badge display**: Shows workspace's PR as a clickable badge in the workspace header - **PR status enrichment**: Fetches PR state (open/merged/closed), mergeability, and draft status - **Generic links dropdown**: Non-PR URLs displayed in a scrollable dropdown with copy functionality ## Architecture ### Two separate concerns 1. **PR detection** (badge): Branch-based via `gh pr view` - robust, doesn't depend on chat content 2. **Link extraction** (dropdown): Scans chat for URLs - shows relevant links mentioned in conversation ### PR detection flow ``` WorkspaceLinks mounts → monitorWorkspace(workspaceId) → gh pr view --json ... (no URL = current branch) → PRStatusStore caches result → useWorkspacePR(workspaceId) returns PR with status ``` ### Link extraction robustness - Only scans **complete** text parts (triggered on `tool-call-start` or `stream-end`) - Rescans after compaction to catch URLs split across deltas - Tracks occurrence count and last-seen timestamp ### Design decisions - Links derived from message history on load, **not persisted to localStorage** - PR badge comes from branch detection, **not** from chat-extracted PR links - Dropdown sorted by occurrence count (most seen first), then recency ## UX Features - Copy button on each link in dropdown - Hover tooltip shows full URL + "Seen N times · Last seen X ago" - Scrollable dropdown (max 10 visible, all accessible via scroll) - PR badge shows status icons (draft, checks, mergeability) --- _Generated with `mux` • Model: `${MUX_MODEL_STRING:-unknown}` • Thinking: `${MUX_THINKING_LEVEL:-unknown}` • Cost: `$${MUX_COSTS_USD:-unknown}`_

chatgpt-codex-connector bot reviewed Jan 14, 2026

View reviewed changes

src/browser/utils/messages/StreamingMessageAggregator.ts Outdated Show resolved Hide resolved

src/browser/components/LinksDropdown.tsx Outdated Show resolved Hide resolved

ammar-agent force-pushed the links-1gg2 branch from e7c7e17 to 37a8818 Compare January 14, 2026 17:37

ammar-agent force-pushed the links-1gg2 branch from 37a8818 to 82c46d2 Compare January 14, 2026 17:40

chatgpt-codex-connector bot reviewed Jan 14, 2026

View reviewed changes

src/browser/utils/messages/StreamingMessageAggregator.ts Outdated Show resolved Hide resolved

ammar-agent force-pushed the links-1gg2 branch from 82c46d2 to 62646e5 Compare January 14, 2026 17:45

ammar-agent force-pushed the links-1gg2 branch from 62646e5 to 00a347b Compare January 14, 2026 17:48

chatgpt-codex-connector bot reviewed Jan 14, 2026

View reviewed changes

src/browser/utils/messages/StreamingMessageAggregator.ts Outdated Show resolved Hide resolved

src/browser/utils/messages/StreamingMessageAggregator.ts Outdated Show resolved Hide resolved

ammar-agent force-pushed the links-1gg2 branch from 00a347b to 621b206 Compare January 14, 2026 17:51

ammar-agent force-pushed the links-1gg2 branch from 621b206 to 6994d60 Compare January 14, 2026 17:56

chatgpt-codex-connector bot reviewed Jan 14, 2026

View reviewed changes

src/browser/utils/messages/StreamingMessageAggregator.ts Outdated Show resolved Hide resolved

ammar-agent force-pushed the links-1gg2 branch from 6994d60 to e831f0e Compare January 14, 2026 17:59

ammar-agent force-pushed the links-1gg2 branch 14 times, most recently from 0d79e24 to 2b90d9b Compare January 14, 2026 19:39

ammar-agent force-pushed the links-1gg2 branch from 2b90d9b to 5aaf2cb Compare January 14, 2026 19:48

ammario merged commit 2584f69 into main Jan 14, 2026
20 checks passed

ammario deleted the links-1gg2 branch January 14, 2026 19:52

chatgpt-codex-connector bot reviewed Jan 14, 2026

View reviewed changes

🤖 feat: add first-class link support with PR status badges #1623

🤖 feat: add first-class link support with PR status badges #1623

Uh oh!

Conversation

ammar-agent commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Features

Architecture

Two separate concerns

PR detection flow

Link extraction robustness

Design decisions

UX Features

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ammar-agent commented Jan 14, 2026

CI Status

Uh oh!

ammar-agent commented Jan 14, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ammar-agent commented Jan 14, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ammar-agent commented Jan 14, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ammar-agent commented Jan 14, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ammar-agent commented Jan 14, 2026 •

edited

Loading