Add zizmor security analysis + harden workflows#427
Merged
Conversation
- Pin all actions (docker/*, actions/*) to commit SHAs at their latest releases - Add explicit permissions: workflow-level contents: read; packages: write on the build and merge jobs (ghcr push via GITHUB_TOKEN) - Add concurrency limits and persist-credentials: false on checkouts - Pass matrix/env/step values via step env to avoid template injection, and use jq --arg for the registry slugs in the manifest-merge steps - determine-composer-version action: emit step outputs instead of writing to $GITHUB_ENV (avoids the github-env code-execution vector) - Give all jobs explicit names
Member
|
Aside from whitespace nitpicking (most files use 2 spaces indent, new file uses 4); everything looks OK. Using --arg for jq is also a safer approach, nice catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
zizmorGitHub Actions security-analysis workflow (pedantic, matchingcomposer/packagist) and adependabot.yml(github-actions, monthly + 7-day cooldown), and hardens the existing build/shellcheck workflows so zizmor passes:docker/*,actions/*) to a commit SHA at its latest release.contents: read;packages: writeadded to thebuildandmergejobs (they push to ghcr.io viaGITHUB_TOKEN).persist-credentials: falseon checkouts.matrix.platform, build digests and registry slugs into stepenv, and usedjq --argfor the slugs in the manifest-merge steps (behaviour-preserving — those slugs are already workflowenv).$GITHUB_ENV(removes the github-env code-exec vector); consumers updated tosteps.composer-version.outputs.major-minor-patch.Verified locally with zizmor (pedantic, incl. online audits): no findings.