Skip to content

Conversation

@luwes
Copy link
Collaborator

@luwes luwes commented Jul 15, 2025

fix #1957

@luwes luwes requested a review from Copilot July 15, 2025 14:36
@luwes luwes self-assigned this Jul 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates multiple video and audio element dependencies to fix a muted prop bug (issue #1957). The changes update patch versions across several media player libraries to incorporate bug fixes.

  • Updates 8 media element dependencies to newer patch versions
  • Addresses a muted prop bug that was likely affecting multiple video/audio players
  • Maintains compatibility while incorporating upstream bug fixes

@luwes luwes temporarily deployed to github-preview July 15, 2025 14:36 — with GitHub Actions Inactive
@luwes luwes merged commit 0d6d81c into master Jul 15, 2025
12 checks passed
@luwes luwes deleted the fixes branch July 15, 2025 14:51
@cduff
Copy link

cduff commented Jul 16, 2025

@luwes I just tried upgrading react-player to 3.2.1 and when it tries to play a Vimeo video the following exception is thrown:

player.es.js:2290  Uncaught (in promise) TypeError: There must be a value to set.
    at eval (player.es.js:2290:1)
    at new Promise (<anonymous>)
    at Player.set (player.es.js:2287:1)
    at Player.setMuted (player.es.js:3111:1)
    at eval (vimeo-video-element.js:373:1)

I'm guessing it's caused by this change?

This happens when no explicit muted prop value is set (should default to false).
If I explicitly set muted={false} then the exception no longer occurs.

@luwes
Copy link
Collaborator Author

luwes commented Jul 16, 2025

thanks for reporting, that looks like a bug in https://github.com/vimeo/player.js
could you provide a codesandbox?

@cduff
Copy link

cduff commented Jul 16, 2025

thanks for reporting, that looks like a bug in https://github.com/vimeo/player.js could you provide a codesandbox?

Sure @luwes, here you go, minimal reproduction:
https://codesandbox.io/p/sandbox/react-player-vimeo-muted-bug-5xr58p

Basically just:

export default function App() {
  return <ReactPlayer src="https://vimeo.com/90509568" />;
}

@luwes
Copy link
Collaborator Author

luwes commented Jul 16, 2025

thank you!
fixed in v3.3 https://codesandbox.io/p/sandbox/react-player-vimeo-muted-bug-forked-kh34q9?file=%2Fsrc%2FApp.tsx

@cduff
Copy link

cduff commented Jul 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Muted state doesn't work on HLS Player for v3

3 participants