-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: muted prop bug #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: muted prop bug #1959
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates multiple video and audio element dependencies to fix a muted prop bug (issue #1957). The changes update patch versions across several media player libraries to incorporate bug fixes.
- Updates 8 media element dependencies to newer patch versions
- Addresses a muted prop bug that was likely affecting multiple video/audio players
- Maintains compatibility while incorporating upstream bug fixes
|
@luwes I just tried upgrading I'm guessing it's caused by this change? This happens when no explicit |
|
thanks for reporting, that looks like a bug in https://github.com/vimeo/player.js |
Sure @luwes, here you go, minimal reproduction: Basically just: export default function App() {
return <ReactPlayer src="https://vimeo.com/90509568" />;
} |
|
thank you! |
Thanks @luwes! |
fix #1957