Security: add flags for TCP connection limits and timeouts#7518
Open
SungJin1212 wants to merge 7 commits into
Open
Security: add flags for TCP connection limits and timeouts#7518SungJin1212 wants to merge 7 commits into
SungJin1212 wants to merge 7 commits into
Conversation
SungJin1212
force-pushed
the
feat/memberlist-tcp-security-limits
branch
2 times, most recently
from
6c101cc to
ac76ac2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
Author
|
@friedrichg |
friedrichg
approved these changes
May 15, 2026
Member
friedrichg
left a comment
friedrichg
left a comment
There was a problem hiding this comment.
Just one more nit. Pre-approved!
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
feat/memberlist-tcp-security-limits
branch
2 times, most recently
from
96de558 to
33dca62
Compare
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
feat/memberlist-tcp-security-limits
branch
from
33dca62 to
6974569
Compare
friedrichg
reviewed
May 18, 2026
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
friedrichg
approved these changes
May 18, 2026
danielblando
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds TCP connection flags to address the security issues.
-memberlist.packet-read-timeout: Read deadline applied to every inbound packet connection. Connections that do not complete within this window are closed.-memberlist.max-packet-size: Maximum size of a single inbound gossip packet. Enforced viaio.LimitReaderbeforeio.ReadAll, preventing heap exhaustion from oversized payloads. Applies to packet-type messages only.-memberlist.max-concurrent-connections: Maximum number of concurrent inbound TCP connections. Connections exceeding this limit are rejected immediately.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags