Skip to content

Fix #7959 invalidPrintfArgType_uint false positive #8534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 5 commits into from
May 7, 2026
+17 −2
Merged

Fix #7959 invalidPrintfArgType_uint false positive #8534

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3a5a90
Update checkio.cpp
chrchr-github May 6, 2026
51ba854
Update testio.cpp
chrchr-github May 6, 2026
4ad6cb1
Update testio.cpp
chrchr-github May 6, 2026
20d3a29
Update checkio.cpp
chrchr-github May 6, 2026
658022f
Merge branch 'cppcheck-opensource:main' into chr_7959
chrchr-github May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/checkio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1539,9 +1539,9 @@
if (element && isStdVectorOrString()) { // isStdVectorOrString sets type token if true
element = false; // not really an array element
} else if (variableInfo->isEnumType()) {
if (variableInfo->type() && variableInfo->type()->classScope && variableInfo->type()->classScope->enumType)
if (variableInfo->type() && variableInfo->type()->classScope && variableInfo->type()->classScope->enumType && variableInfo->type()->classScope->enumType->isStandardType())

Check failure

Code scanning / Cppcheck Premium

Either the condition 'variableInfo->type()' is redundant or there is possible null pointer dereference: variableInfo->type(). High

Either the condition 'variableInfo->type()' is redundant or there is possible null pointer dereference: variableInfo->type().

Check failure

Code scanning / Cppcheck Premium

Either the condition 'variableInfo->type()->classScope' is redundant or there is possible null pointer dereference: variableInfo->type()->classScope. High

Either the condition 'variableInfo->type()->classScope' is redundant or there is possible null pointer dereference: variableInfo->type()->classScope.
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
typeToken = variableInfo->type()->classScope->enumType;
else {
else if (!variableInfo->type()->classScope->enumType) {
tempToken = new Token(tok1);
tempToken->str("int");
typeToken = tempToken;
Expand Down
14 changes: 14 additions & 0 deletions test/testio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3371,6 +3371,20 @@ class TestIO : public TestFixture {
"}");
ASSERT_EQUALS("", errout_str());

check("enum E : uint8_t { E0 }; \n" // #7959
"void f(E e) {\n"
" printf(\"%hhu\", e);\n"
"}");
ASSERT_EQUALS("", errout_str());

check("enum E : uint8_t { E0 }; \n"
"void f(E e) {\n"
" printf(\"%lu\", e);\n"
"}");
TODO_ASSERT_EQUALS("[test.cpp:3]: (warning) %lu in format string (no. 1) requires 'unsigned long' but the argument type is 'uint8_t'.\n",
"",
errout_str());

check("void f() {\n"
" printf(\"%lu\", sizeof(char));\n"
"}\n", dinit(CheckOptions, $.portability = true, $.platform = Platform::Type::Win64));
Expand Down
Loading