Skip to content

Fix #12320 FP knownConditionTrueFalse with strtok()#8547

Open
chrchr-github wants to merge 2 commits into
cppcheck-opensource:mainfrom
chrchr-github:chr_12320
Open

Fix #12320 FP knownConditionTrueFalse with strtok()#8547
chrchr-github wants to merge 2 commits into
cppcheck-opensource:mainfrom
chrchr-github:chr_12320

Conversation

@chrchr-github
Copy link
Copy Markdown
Collaborator

No description provided.

@chrchr-github chrchr-github marked this pull request as ready for review May 11, 2026 08:58
@firewave
Copy link
Copy Markdown
Collaborator

We should probably add an explicit ProgramMemory test. I would also be interested in more details why this differed between compilers.

@chrchr-github
Copy link
Copy Markdown
Collaborator Author

std::unordered_map makes not guarantees about the order of the elements. And in this case, the content of the map is used to determine if an element should be erased. That logic might still have problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants