Skip to content

add pecl source type so we don't get ancient protobuf versions#1074

Closed
henderkes wants to merge 3 commits intomainfrom
fix/protobuf
Closed

add pecl source type so we don't get ancient protobuf versions#1074
henderkes wants to merge 3 commits intomainfrom
fix/protobuf

Conversation

@henderkes
Copy link
Copy Markdown
Collaborator

@henderkes henderkes commented Mar 26, 2026

What does this PR do?

adds a dedicated pecl source type so we can:

  • get the latest version, not just the last one released
  • get stable versions instead of beta version (prefer-stable: true, kept this off by default in order to not change existing functionality)

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@henderkes henderkes requested a review from crazywhalecc March 26, 2026 05:17
@crazywhalecc
Copy link
Copy Markdown
Owner

I've already added on v3 though. Do you think we still need to add new features to v2?

@henderkes
Copy link
Copy Markdown
Collaborator Author

Only reason I did it is because my CI started being red because of the pecl release of protobuf v3.

@henderkes
Copy link
Copy Markdown
Collaborator Author

I'll open a new pr instead, let's close this.

@henderkes henderkes closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants