-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Improving the VoyageAI integration #3705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Supporting contextual models Extending the tests
Supporting contextual models Extending the tests
b628e2e to
cc41421
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bug: Default Model Removal Breaks Existing Configurations
Removing the default value for the model field breaks existing code that relies on the previous voyage-2 default. Users who don't explicitly specify a model in their VoyageAI embedder configuration will now encounter validation errors when the provider is instantiated, whereas their code worked before this change.
lib/crewai/src/crewai/rag/embeddings/providers/voyageai/voyageai_provider.py#L17-L21
crewAI/lib/crewai/src/crewai/rag/embeddings/providers/voyageai/voyageai_provider.py
Lines 17 to 21 in da99de1
| ) | |
| model: str = Field( | |
| description="Model to use for embeddings", | |
| validation_alias="EMBEDDINGS_VOYAGEAI_MODEL", | |
| ) |
|
@lorenzejay Can you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Adding contextual model support
Counting the tokens and batching
Tests
Note
Upgrades the VoyageAI embedding stack for performance and model coverage.
count_tokens, with per-model token limits and unified embedding flow (regular, contextual viacontextualized_embed, and multimodal viamultimodal_embed)api_keyandmodelrequired in typesVoyageAIProvidervoyage-4, adds advanced config examples and model overview, and updates RAG Tool config optionsWritten by Cursor Bugbot for commit 15f49d4. This will update automatically on new commits. Configure here.