refs #14599 - do not implicitly print in TimerResults::stop()#8400
Draft
firewave wants to merge 2 commits intodanmar:mainfrom
Draft
refs #14599 - do not implicitly print in TimerResults::stop()#8400firewave wants to merge 2 commits intodanmar:mainfrom
TimerResults::stop()#8400firewave wants to merge 2 commits intodanmar:mainfrom
Conversation
Collaborator
Author
|
Yes, the code is a bit worse. But this is an intermediate step in the separation of the interface and the implementation which preserves the output. It will be improved upon as the refactoring proceeds. |
|
Collaborator
Author
|
Ugh - these recent additions to the timing stuff made a bit of a mess of things by making it even less generic... needs another round to figure out how to handle this without making it too hacky and partially broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.