BLD/DEV: switch to meson-python and pixi-build #583
Conversation
lucascolley
force-pushed
the
meson-python
branch
from
1e7212e to
b2ee65f
Compare
lucascolley
force-pushed
the
meson-python
branch
4 times, most recently
from
a28bd6f to
db58474
Compare
This comment was marked as resolved.
This comment was marked as resolved.
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
Thanks @lucascolley, this looks close. I didn't test yet, but hopefully the comments will be enough to resolve the remaining failures first.
lucascolley
force-pushed
the
meson-python
branch
from
b4efc62 to
bccf112
Compare
lucascolley
left a comment
lucascolley
left a comment
There was a problem hiding this comment.
@rgommers ready to go I think!
| @@ -1,8 +1,8 @@ | |||
| 1. Update the version in `src/array_api_extra/__init__.py` | |||
| 1. Update the version in `pyproject.toml`, `meson.build`, and `src/array_api_extra/__init__.py` | |||
There was a problem hiding this comment.
up to 3 sources now, I don't think pixi-build is smart enough to handle dynamic versioning yet. But I think it's okay.
| [tool.pixi.dev] | ||
| # this pulls in array-api-extra's host and run dependencies | ||
| array-api-extra.path = "." | ||
|
|
||
| [tool.pixi.dependencies] | ||
| array-api-compat = ">=1.12.0,<2" | ||
| array-api-extra.path = "." |
There was a problem hiding this comment.
ideally we wouldn't need both of these, I have asked offline
EDIT: maybe can be simplified in the future but not yet
lucascolley
changed the title
lucascolley
force-pushed
the
meson-python
branch
from
bccf112 to
72c6a74
Compare
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
Overall looks good, a couple of small comments. I didn't test yet, would be good to update the linked SciPy PR so this is easier to verify.
lucascolley
force-pushed
the
meson-python
branch
from
72c6a74 to
3c63640
Compare
|
thanks! CI running on scipy/scipy#24271 with your suggestions here applied |
|
Looks like all worked upstream |
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
LGTM now, modulo the lock file conflict
2 participants
scipy/scipy#24271