Skip to content

Add mirror/keyserver override support across feature installers#1620

Open
bbartels wants to merge 25 commits intodevcontainers:mainfrom
bbartels:main
Open

Add mirror/keyserver override support across feature installers#1620
bbartels wants to merge 25 commits intodevcontainers:mainfrom
bbartels:main

Conversation

@bbartels
Copy link
Copy Markdown

@bbartels bbartels commented Apr 13, 2026

This PR makes feature install scripts mirror/proxy-friendly by introducing env-var-based download base URL overrides while preserving existing defaults when unset. It also adds cross-script keyserver override behavior and updates PowerShell/Ruby/dotnet flows where URL resolution/bootstrap behavior needed structural changes.

  • Cross-cutting mirror/keyserver support

    • Added GITHUB_RELEASE_MIRROR support (via local GITHUB_RELEASE_URL) for GitHub Releases HTTP artifact downloads in affected scripts.
    • Updated shared get_gpg_key_servers() probing helpers to honor GPG_KEYSERVER as a single authoritative keyserver when provided.

  • Per-feature URL override additions

    • github-cli: GitHub release .deb downloads now use GITHUB_RELEASE_URL.
    • nvidia-cuda: NVIDIA_REPO_URL now derives from NVIDIA_MIRROR.
    • rust: exported/persisted RUSTUP_DIST_SERVER and RUSTUP_UPDATE_ROOT.
    • go: added GO_MIRROR for tarball/signature downloads and GO_TAG_SOURCE for tag resolution.
    • node: added/exported NVM_NODEJS_ORG_MIRROR and threaded it across su ... -c boundaries.
    • java: added ADOPTIUM_API_URL (ADOPTIUM_MIRROR), and SDKMAN_SERVICE_MIRROR support via sdkman_api config rewrite.
    • php: added PHP_MIRROR, COMPOSER_MIRROR, COMPOSER_SIG_MIRROR.
    • powershell: added MICROSOFT_PACKAGES_MIRROR + GITHUB_RELEASE_URL; replaced hardcoded Microsoft/GitHub download bases.
    • kubectl-helm-minikube: added KUBECTL_MIRROR, HELM_MIRROR, MINIKUBE_MIRROR, GITHUB_RELEASE_URL; removed non-configurable kubectl fallback URL.
    • python: added PYTHON_MIRROR + GITHUB_RELEASE_URL for CPython/cosign artifacts.
    • terraform: retained CUSTOM_DOWNLOAD_SERVER; added GITHUB_RELEASE_URL for satellite tools and HASHICORP_KEY_URL (HASHICORP_GPG_KEY_MIRROR) for Noble key fetch path.
    • docker-in-docker: added GITHUB_RELEASE_MIRROR, MICROSOFT_PACKAGES_MIRROR, DOCKER_MIRROR support for compose/buildx/switch, Microsoft repo assets, and Docker CE repo/key setup.

  • Required structural adjustments

    • PowerShell: removed aka.ms/powershell-release redirect-based version resolution path; version selection now relies on existing git-tag helpers.
    • Ruby:
      • Added optional git-based RVM bootstrap path when RVM_INSTALL_MIRROR is set (.../rvm/rvm.git + binscripts/rvm-installer stable ...).
      • Added /etc/rvmrc mirror entries for rvm_rubies_url and rvm_binaries_url when corresponding vars are set.
    • Dotnet:
      • DOTNET_RELEASES_INDEX_URL now uses DOTNET_RELEASES_MIRROR fallback pattern.
      • install_sdk() and install_runtime() now append --azure-feed "${DOTNET_RELEASES_MIRROR}" when set.

Example pattern applied across scripts:

GITHUB_RELEASE_URL="${GITHUB_RELEASE_MIRROR:-https://github.com}"
curl -fsSL -o artifact.deb "${GITHUB_RELEASE_URL}/owner/repo/releases/download/v${VERSION}/artifact.deb"

Copilot AI and others added 9 commits April 13, 2026 23:23
Initial plan
9f58a6f
@bbartels
feat: add mirror overrides for feature download URLs
f24ac33 
Agent-Logs-Url: https://github.com/bbartels/features/sessions/47fca3d3-4eb7-487d-9af5-e4b462552066

Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
@bbartels
chore: clean docker mirror variable initialization
c2be3b6 
Agent-Logs-Url: https://github.com/bbartels/features/sessions/47fca3d3-4eb7-487d-9af5-e4b462552066

Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
@bbartels
fix: harden mirror string handling in ruby and java scripts
b0a6037 
Agent-Logs-Url: https://github.com/bbartels/features/sessions/47fca3d3-4eb7-487d-9af5-e4b462552066

Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
@bbartels
fix: address validation feedback in kubectl node ruby
151d0a6 
Agent-Logs-Url: https://github.com/bbartels/features/sessions/47fca3d3-4eb7-487d-9af5-e4b462552066

Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
@bbartels
fix: harden sdkman and ruby mirror config writes
7b5c864 
Agent-Logs-Url: https://github.com/bbartels/features/sessions/47fca3d3-4eb7-487d-9af5-e4b462552066

Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
@bbartels
fix: safely quote ruby mirror values in /etc/rvmrc
8ae2156 
Agent-Logs-Url: https://github.com/bbartels/features/sessions/47fca3d3-4eb7-487d-9af5-e4b462552066

Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
@bbartels
fix: validate RVM_INSTALL_MIRROR input for safe bootstrap
5459890 
Agent-Logs-Url: https://github.com/bbartels/features/sessions/47fca3d3-4eb7-487d-9af5-e4b462552066

Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
@bbartels
Merge pull request #1 from bbartels/copilot/update-download-base-url-…
0f60769 
…support

Add mirror/keyserver override support across feature installers (incl. dotnet feed wiring)
@bbartels bbartels requested a review from a team as a code owner April 13, 2026 23:53
@bbartels
Copy link
Copy Markdown
Author

bbartels commented Apr 13, 2026

@microsoft-github-policy-service agree

Copilot AI and others added 8 commits April 14, 2026 00:03
@bbartels
fix(powershell): restore aka.ms version resolution with resilient fal…
4832ef9 
…lback

Agent-Logs-Url: https://github.com/bbartels/features/sessions/e1ae3385-4a58-45e6-ab36-dd2e1c4ea537

Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
@bbartels
chore(powershell): address validation feedback on fallback resolver
b88bf1b 
Agent-Logs-Url: https://github.com/bbartels/features/sessions/e1ae3385-4a58-45e6-ab36-dd2e1c4ea537

Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
@bbartels
fix(powershell): harden version parsing and metadata fallback diagnos…
8e07b48 
…tics

Agent-Logs-Url: https://github.com/bbartels/features/sessions/e1ae3385-4a58-45e6-ab36-dd2e1c4ea537

Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
@bbartels
fix(powershell): handle metadata fetch failures correctly
aa0d4dc 
Agent-Logs-Url: https://github.com/bbartels/features/sessions/e1ae3385-4a58-45e6-ab36-dd2e1c4ea537

Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
@bbartels
fix: restore kubectl secondary fallback URL and simplify ruby rvmrc m…
fb764c5 
…irror writes

Agent-Logs-Url: https://github.com/bbartels/features/sessions/58d9ab00-c56e-435b-a7c0-72bc0d413cdb

Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
@bbartels
revert: restore powershell to upstream form, keeping only mirror URL …
a4b5d81 
…additions

Agent-Logs-Url: https://github.com/bbartels/features/sessions/e372413f-942b-4e04-bc36-e4e1d8707978

Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
@bbartels
feat: add minimal metadata.json fallback when aka.ms is unreachable
c7a1359 
Agent-Logs-Url: https://github.com/bbartels/features/sessions/fc3bae77-8d60-43af-970f-a51666be21e4

Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
@bbartels
Merge pull request #2 from bbartels/copilot/add-env-var-url-overrides
aa90fe7 
fix: make PowerShell aka.ms version resolution resilient with fallback
bbartels
bbartels commented Apr 14, 2026
View reviewed changes
bbartels
bbartels commented Apr 14, 2026
View reviewed changes
@bbartels
Apply suggestions from code review
e8a08af 
Co-authored-by: Benjamin Bartels <benjamin@bartels.dev>
bbartels
bbartels commented Apr 14, 2026
View reviewed changes
bbartels
bbartels commented Apr 14, 2026
View reviewed changes
bbartels
bbartels commented Apr 14, 2026
View reviewed changes
bbartels
bbartels commented Apr 14, 2026
View reviewed changes
bbartels
bbartels commented Apr 14, 2026
View reviewed changes
@bbartels
Apply suggestions from code review
9aab57c 
Co-authored-by: Benjamin Bartels <benjamin@bartels.dev>
bbartels
bbartels commented Apr 14, 2026
View reviewed changes
Copilot AI mentioned this pull request Apr 14, 2026
Merged
Copilot AI and others added 2 commits April 14, 2026 01:19
@bbartels
chore: bump minor versions for mirror/keyserver feature updates
eb0d354 
Agent-Logs-Url: https://github.com/bbartels/features/sessions/f4770407-c8bf-457f-91d4-9ed1af88d766

Co-authored-by: bbartels <23058572+bbartels@users.noreply.github.com>
@bbartels
Merge pull request #3 from bbartels/copilot/bump-feature-versions
c9225b0 
Bump minor feature versions for mirror/keyserver-updated manifests
@bbartels
Copy link
Copy Markdown
Author

bbartels commented Apr 14, 2026

Hi @abdurriq , we've been trying to get devcontainers to work internally. Unfortunately, we have an air-gapped on-prem setup here with an artifactory proxy that allows us to mirror releases/package repositories etc. This PR makes it so that an initial batch of features support overriding artifact urls so we dont need to maintain an internal fork that overrides baseurls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bbartels