fix: backup job handles workspace with no storage #1573
Conversation
The function will be used across both backup and restore features and should be accessed multiple places. Signed-off-by: Ales Raszka <[email protected]>
Workspace with no storage failed in the backup process. This commit fixes it by checking if the volumes are present and skip the job if no pvc is available. fixes: 1555 Signed-off-by: Ales Raszka <[email protected]>
Allda
requested review from
akurinnoy,
dkwon17,
ibuziuk and
rohanKanojia
as code owners
|
@Allda: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Allda, dkwon17 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Skip backup if the workspace is missing volumes
Workspace with no storage failed in the backup process. This commit
fixes it by checking if the volumes are present and skips the job if no
pvc is available.
fixes: 1555
What issues does this PR fix or reference?
#1555
Is it tested? How?
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che