fix: coroutine close_async_caches was never awaited#87
Open
joshpwrk wants to merge 2 commits intodjango-commons:mainfrom
Open
fix: coroutine close_async_caches was never awaited#87joshpwrk wants to merge 2 commits intodjango-commons:mainfrom
close_async_caches was never awaited#87joshpwrk wants to merge 2 commits intodjango-commons:mainfrom
Conversation
Member
|
hello 👋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When using WSGI servers with django_valkey you get the following error:
/usr/local/lib/python3.10/site-packages/django/http/response.py:335: RuntimeWarning: coroutine 'close_async_caches' was never awaitedReason:
The current implementation connects an async connection closer to
request_finished, which creates un-awaited coroutines in WSGI environments where no event loop exists. Although the implementation checks whether the Valkey objectis_async, the function itself is defined asawait defand thus throws an error.Furthermore, even if users set
CLOSE_CONNECTION = False, this does not prevent django from running the buggyclose_async_cachesfunction.Solution:
Create separate sync and async handlers, and only connect the async version when async backends are detected.