[WIP] replace direct uses of logrus for containerd/log #5149
+107
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
thaJeztah
force-pushed
the
cd8_logs
branch
3 times, most recently
from
23a6c37 to
95fbbbd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thaJeztah
force-pushed
the
cd8_logs
branch
3 times, most recently
from
d147de2 to
67e4aff
Compare
|
|
||
| func (w *stderrWriter) Write(p []byte) (int, error) { | ||
| logrus.Debugf("%s%s", w.debugPrefix, string(p)) | ||
| log.G(context.TODO()).Debug(w.debugPrefix + string(p)) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
thaJeztah
force-pushed
the
cd8_logs
branch
5 times, most recently
from
bde69ca to
17032dc
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
- remove constructor - fix mixed pointer/non-pointer receivers - just embed the error we want to produce Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)