Skip to content

pkg/compose: go fix#13782

Merged
ndeloof merged 1 commit into
docker:mainfrom
thaJeztah:go_fix
May 11, 2026
Merged

pkg/compose: go fix#13782
ndeloof merged 1 commit into
docker:mainfrom
thaJeztah:go_fix

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

What I did

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copilot AI review requested due to automatic review settings May 7, 2026 22:32
@thaJeztah thaJeztah requested a review from a team as a code owner May 7, 2026 22:32
@thaJeztah thaJeztah requested review from glours and ndeloof May 7, 2026 22:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates a small string helper in the Compose plugin execution path to use a more idiomatic standard-library API for extracting the first line of a message.

Changes:

  • Replace manual newline search (strings.IndexByte) with strings.Cut in firstLine.

Copy link
Copy Markdown

@docker-agent docker-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR refactors in to use instead of + manual slicing. The two approaches are semantically equivalent — no bugs introduced.

Copy link
Copy Markdown

@docker-agent docker-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR refactors firstLine in pkg/compose/plugins.go to use strings.Cut instead of strings.IndexByte + manual slicing. The two approaches are semantically equivalent — no bugs introduced.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/compose/plugins.go 0.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@thaJeztah
Copy link
Copy Markdown
Member Author

🎉 Got 3 bots (one of which TWICE) that like my PR 😂

@ndeloof ndeloof merged commit 8854550 into docker:main May 11, 2026
46 checks passed
@thaJeztah thaJeztah deleted the go_fix branch May 11, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants