feat(spec)!: drop Persistence/KitDir, add locked/resources, list mounts

[mdelapenya]

What's changed

Five field-scoped, breaking-but-experimental changes to the kit spec, each a separate commit:

• Remove Manifest.Persistence — declared on the manifest, parsed, inherited, displayed, but no runtime decision consumed it. Volumes are already explicit via Manifest.Volumes.
• Remove Manifest.KitDir — same shape as Persistence: stored, copied during inheritance, rendered by inspect commands, but never consulted at runtime. No kit declares it.
• Add top-level locked — a list of dotted YAML paths that child kits must not override during extends: resolution. The spec library only validates well-formedness; enforcement is the merge consumer's job.
• Add agent.resources — optional container resource constraints (cpu as float64 cores, memoryMB as int64, gpu as a consumer-defined string).
• Switch volumes/tmpfs to list form with a shared MountSpec — both Manifest.Volumes and Manifest.Tmpfs move from map[string]string (with packed option strings) to []MountSpec{Path, Size, Mode}. The two fields share one entry type since their per-entry shape is identical; the semantic distinction lives on the slice field.

TCK gains pure-logic sub-tests for locked and resources, and iterates the slice form for volumes and tmpfs. Agent ttl is intentionally deferred — there are unresolved comments on the proposal that need to land first.

Why is this important?

The kit spec accumulated fields that looked configurable but had no effect — Persistence and KitDir were declared and validated but never read. Removing them clears the kit-author surface and avoids the fiction that they do something.

The two additive fields come from the next phase of kit-author requests: locked gives parent kits a way to protect critical fields from being overridden, and resources declares container limits that the engine will wire to the runtime (matters most for cloud workloads, where CPU/memory/GPU constraints aren't always inherited from the host).

The mount restructure replaces a flat map whose values had to pack options into a single string ("size=512m,mode=1777") — awkward to validate, awkward to extend — with a discrete list-of-struct form. Volumes and tmpfs share MountSpec because their fields are identical; the validators delegate to one shared validateMounts helper that supplies the field name as the error prefix, so failures still read volumes[i] or tmpfs[i].

Kits are documented as experimental, so the removals and shape change don't require a schema bump.

Changes

spec/

• Drop PersistenceEphemeral/PersistencePersistent constants, Manifest.Persistence, agentBlock.Persistence, the flat-field rejection in normalize, and the persistence rule in ValidateManifest.
• Drop Manifest.KitDir.
• Add Artifact.Locked []string and specFile.Locked parsing; add ValidateLocked (rejects empty entries, malformed dotted paths, duplicates).
• Add Resources type, Manifest.Resources, agentBlock.Resources, normalize wiring, and non-negative CPU/memory validation in ValidateManifest.
• Introduce MountSpec{Path, Size, Mode} used by both Manifest.Volumes and Manifest.Tmpfs. Collapse ValidateVolumes/ValidateTmpfs into thin wrappers around a shared validateMounts(field, mounts) helper.

tck/

• Drop the persistence sub-test from RunValidationTests.
• Add a locked sub-test that mirrors spec.ValidateLocked.
• Add a resources sub-test asserting CPU and MemoryMB are non-negative.
• Volumes/tmpfs pure-logic sub-tests iterate the slice form.
• deriveTmpfs takes []spec.MountSpec and composes the comma-separated option string Docker expects from Size/Mode, preserving the existing runtime assertTmpfs check unchanged.

Pure-logic only — runtime container assertions for resources (applying limits via testcontainers and inspecting HostConfig) were considered but kept out of scope. Resource enforcement is the engine's responsibility, and the TCK should not pretend to be the engine.

Kits

Eight kit specs drop their no-op persistence: persistent lines: amp, claude-ollama, nanobot, nanoclaw, openclaw, opencode-model-runner, pi, trivy. No contrib kit declared volumes: or tmpfs: in yaml, so kit specs are otherwise unchanged.

Migration

Downstream consumers of this library will need to:

1. Bump the dep to pick up the new types.
2. Drop their own dead references to Manifest.Persistence and Manifest.KitDir.
3. Adapt their volume and tmpfs customizers from map[string]string to []spec.MountSpec. The packed option string ("size=10g") is now discrete fields; the consumer composes whatever runtime form Docker expects.
4. Wire agent.resources to the container runtime when ready to enforce limits.
5. Wire locked into the inheritance merge step to actually reject child overrides.

Test plan

• go test ./... passes across all 15 packages in this repo (spec, tck, and every kit's integration tests).
• All five commits are GPG-signed and DCO signed-off.
• Downstream consumer adapter PRs follow separately.