-
Notifications
You must be signed in to change notification settings - Fork 229
FIX: Add retry mechanism with exponential backoff for buildkit bootstrap step #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielamar101-pton
wants to merge
3
commits into
docker:master
Choose a base branch
from
danielamar101-pton:fix-buildx-bootstrap-race-condition
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−7
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
38b3aa6
Add retry mechanism with exponential backoff for buildkit bootstrap
danielamar101-pton 3d8b1e8
Add timeout control to prevent long waits during buildkit initialization
danielamar101-pton 41d4d4a
remove retry only on certain errors. maxRetries set to 3 instead of 5.
danielamar101-pton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this timeout promise,
inspectcommand already have some timeout: https://github.com/docker/buildx/blob/ea2b7020a4645bff395eb49e4e87ef08ba24eb93/commands/inspect.go#L38-L40Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This timeout is the core of the change however, as we found sometimes this command execution can hang during high resource contention, in particular IO bottlenecks, in our infrastructure.
This approach is a classic example of the "end-to-end principle" in distributed systems - reliability mechanisms at lower layers can't always account for failures at higher layers, so an additional timeout at the highest level provides more comprehensive protection against various failure modes across the entire stack.