Skip to content

Fix aspnet2 spmi #123154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EgorBo merged 1 commit into from
Jan 14, 2026
Merged

Fix aspnet2 spmi #123154

EgorBo merged 1 commit into from
Jan 14, 2026
+11 −3

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Jan 13, 2026

No description provided.

@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 13, 2026
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jan 13, 2026

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@EgorBo
Copy link
Member Author

EgorBo commented Jan 13, 2026

/azp run runtime-coreclr superpmi-collect-test

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 13, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@EgorBo EgorBo marked this pull request as ready for review January 14, 2026 14:37
Copilot AI review requested due to automatic review settings January 14, 2026 14:37
@EgorBo
Copy link
Member Author

EgorBo commented Jan 14, 2026 •
edited
Loading

PTAL @dotnet/jit-contrib @AndyAyersMS - this fixes the aspnet2 collection, I don't know why crank refuses to download the SDK for net11 internally + edge/latest channel 😞 I just took the latest version from https://aka.ms/aspnet/benchmarks and it works (it's also still on net10).

@EgorBo EgorBo requested a review from AndyAyersMS January 14, 2026 14:39
Copilot AI reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the aspnet2 SPMI collection script by temporarily pinning specific .NET 10.0 RTM versions to work around issues with using dynamic version channels. The script previously attempted to use the "latest" channel but encountered build failures.

Changes:

  • Commented out the dynamic framework/channel configuration that was causing failures
  • Pinned to specific .NET 10.0 RTM versions (aspNetCoreVersion, runtimeVersion, and sdkVersion)
  • Added a TODO comment noting this is a temporary workaround

AndyAyersMS
AndyAyersMS approved these changes Jan 14, 2026
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why either, but this is fine for now.

@EgorBo EgorBo merged commit 9d6182c into dotnet:main Jan 14, 2026
100 checks passed
@EgorBo EgorBo deleted the fix-aspnet2 branch January 14, 2026 21:40
@dotnet-maestro dotnet-maestro bot mentioned this pull request Jan 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@EgorBo EgorBo

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EgorBo @AndyAyersMS