fix: bring back action props and update the hooks to use TypeScript fully#1683
Merged
Conversation
silviuaavram
changed the title
silviuaavram
force-pushed
the
dev/update-to-ts-2
branch
from
34785e9 to
3ee0dfc
Compare
silviuaavram
force-pushed
the
dev/update-to-ts-2
branch
from
14afb57 to
bcf0b4c
Compare
silviuaavram
force-pushed
the
dev/update-to-ts-2
branch
from
a5de25b to
84c7341
Compare
4 tasks
silviuaavram
changed the title
|
🎉 This PR is included in version 9.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What
Refactors the hooks to TypeScript.
Brings back the
propsobject as part of theactionobject when is passed to the hook reducer, via theuseEnhancedReducer, in order to fix the issue below:Closes #1680
Closes #1678
Why
Improve DevEx and remove the gap between the static types and the actual implementation.
How
Refactor useSelect and useCombobox + the utils they are using.
Changes
Checklist