Add optional file logging, and add logging for heartbeat disconnects#160
Open
Trogluddite wants to merge 2 commits intoekzhang:mainfrom
Open
Add optional file logging, and add logging for heartbeat disconnects#160Trogluddite wants to merge 2 commits intoekzhang:mainfrom
Trogluddite wants to merge 2 commits intoekzhang:mainfrom
Conversation
Trogluddite
commented
Mar 26, 2025
| loop { | ||
| if stream.send(ServerMessage::Heartbeat).await.is_err() { | ||
| // Assume that the TCP connection has been dropped. | ||
| info!(peer_addr, "connection dropped after heartbeat timeout"); |
Author
There was a problem hiding this comment.
Example log events:
2025-03-26T21:40:35.281814Z INFO control{addr=172.31.11.42:49554}: bore_cli::server: connection dropped after heartbeat timeout peer_addr="172.31.11.42:49554"
2025-03-26T21:40:35.281852Z INFO control{addr=172.31.11.42:49554}: bore_cli::server: connection exited
This just gives us a little more info about why the client disconnected.
5bf6e1b to
b11a705
Compare
Author
|
Hi! I'm following up on older PR's -- is there any chance this will be merged? |
5868315 to
7ce2202
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds:
Testing
Existing unit tests pass; no new tests added.
Basic functional testing (listed below) was made with
releasebuilds on these targets:Test build using (on both linux and MacOS):
rustc 1.85.1 (4eb161250 2025-03-15)
LLVM version: 19.1.7
New Dependencies:
time = "0.3.35"
tracing-appender = "0.2.3"