feat(agents-desktop): bundle Electric CLI#4440
Merged
Merged
Conversation
Contributor
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4440 +/- ##
===========================================
+ Coverage 34.26% 59.26% +24.99%
===========================================
Files 189 313 +124
Lines 14425 32658 +18233
Branches 4929 9028 +4099
===========================================
+ Hits 4943 19354 +14411
- Misses 9468 13286 +3818
- Partials 14 18 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kevin-dp
approved these changes
May 29, 2026
| }, | ||
| getCli() { | ||
| ctx.services.cli ??= createCliController() | ||
| return ctx.services.cli |
Contributor
There was a problem hiding this comment.
No need to repeat, we could simplify to:
return (ctx.services.cli ??= createCliController())Package the Electric CLI with the desktop app and surface managed install status in onboarding and settings. Co-authored-by: Cursor <cursoragent@cursor.com>
Declare the CLI workspace as a desktop dev dependency so filtered desktop CI installs include its build tooling. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove the exploratory plan document from the PR while leaving the local copy untracked. Co-authored-by: Cursor <cursoragent@cursor.com>
2ec98e8 to
7716d72
Compare
Contributor
Electric Agents Mobile BuildAndroid preview build for commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
electric-axCLI artifact into Electric Agents Desktop and run it via Electron's Node runtime.electriccommand detection/install/uninstall IPC plus onboarding and Settings surfaces for CLI status.electric-ax,@electric-ax/agents-desktop, and@electric-ax/agents-server-ui.Stack
samwillis/auto-start) because this extends the Config onboarding step introduced there.Screenshots
Test plan
PATH="$HOME/.asdf/shims:$HOME/.asdf/bin:$PATH" pnpm --filter @electric-ax/agents-desktop typecheckPATH="$HOME/.asdf/shims:$HOME/.asdf/bin:$PATH" pnpm --filter @electric-ax/agents-server-ui typecheckPATH="$HOME/.asdf/shims:$HOME/.asdf/bin:$PATH" pnpm --filter electric-ax build && PATH="$HOME/.asdf/shims:$HOME/.asdf/bin:$PATH" pnpm --filter electric-ax exec node dist/index.js --versionPATH="$HOME/.asdf/shims:$HOME/.asdf/bin:$PATH" pnpm --filter @electric-ax/agents-desktop buildMade with Cursor