Skip to content

fix(agents-desktop): prefer live Cloud server metadata#4443

Merged
icehaunter merged 2 commits into
mainfrom
fix/cloud-server-shape-overlay
Jun 1, 2026
Merged

fix(agents-desktop): prefer live Cloud server metadata#4443
icehaunter merged 2 commits into
mainfrom
fix/cloud-server-shape-overlay

Conversation

@KyleAMathews
Copy link
Copy Markdown
Contributor

Summary

  • Overlay live Electric Cloud agent server metadata onto saved desktop server entries
  • Prefer the Cloud shape stream name for saved Cloud servers, with the local settings name as fallback
  • Reuse the computed Cloud flag when building available server entries

Testing

  • pnpm install
  • pnpm --dir packages/agents-server-ui typecheck
  • git diff --check

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

Electric Agents Desktop Builds

Build artifacts for commit 48ece6e.

Platform Status Artifact
macOS Apple Silicon Passed DMG
macOS Intel Passed DMG
Windows x64 Building Installer
Linux x64 Passed AppImage / deb

Workflow run

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.43%. Comparing base (b2ddd59) to head (50888e2).
⚠️ Report is 10 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../agents-server-ui/src/hooks/useAvailableServers.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4443       +/-   ##
===========================================
- Coverage   85.41%   34.43%   -50.99%     
===========================================
  Files           2      188      +186     
  Lines          48    14355    +14307     
  Branches       11     4900     +4889     
===========================================
+ Hits           41     4943     +4902     
- Misses          7     9398     +9391     
- Partials        0       14       +14     
Flag Coverage Δ
packages/agents-mobile 85.41% <ø> (ø)
packages/agents-server 75.14% <ø> (?)
packages/agents-server-ui 5.70% <0.00%> (?)
typescript 34.43% <0.00%> (-50.99%) ⬇️
unit-tests 34.43% <0.00%> (-50.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

Electric Agents Mobile Build

Android preview build for commit 48ece6e.

Platform Profile Status Build
Android preview Passed EAS build

Workflow run

Copy link
Copy Markdown
Contributor

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just missing a changeset.

@icehaunter icehaunter merged commit 86643d5 into main Jun 1, 2026
17 checks passed
@icehaunter icehaunter deleted the fix/cloud-server-shape-overlay branch June 1, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants