ci: harden privileged PR workflows#4450
Merged
Merged
Conversation
icehaunter
requested changes
Jun 1, 2026
| "url":"https://api.github.com/repos/electric-sql/electric/actions/workflows/leave_benchmark_comment.yml/dispatches", | ||
| "body": "{\"ref\":\"main\",\"inputs\":{\"pr\":\"${{ github.event.issue.number }}\",\"benchmark_info\":#{benchmark_info},\"original_commit\":\"${{ env.SHORT_SHA }}\"}}" | ||
| } | ||
| "short_version": "pr-${{ github.event.issue.number }}-${{ env.SHORT_SHA }}" |
Contributor
There was a problem hiding this comment.
Why is this removing our own infra work of benchmarking leaving GH comments?
KyleAMathews
force-pushed
the
horton/ci-immediate-supply-chain-fixes-clean
branch
from
4c5d168 to
1718113
Compare
Contributor
Author
|
Addressed @icehaunter review: restored the benchmark callback blocks so result comments continue to work, while keeping the same-repo/member-owner hardening. |
Contributor
Author
|
Updated CODEOWNERS to list all current repository admins instead of a single owner. GitHub CODEOWNERS can also use teams, but explicit admins matches the review suggestion. |
KyleAMathews
force-pushed
the
horton/ci-immediate-supply-chain-fixes-clean
branch
from
1718113 to
2a95b8a
Compare
icehaunter
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Immediate CI supply-chain hardening following the TanStack incident audit:
Validation
Note: this PR is from the clean branch horton/ci-immediate-supply-chain-fixes-clean and contains only the immediate CI hardening commit.