-
Notifications
You must be signed in to change notification settings - Fork 216
feat: add optional extras for cloud storage and notification clients #2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
10
commits into
master
Choose a base branch
from
devin/1774117812-optional-extras
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
54bdef6
feat: add optional extras for cloud storage and notification clients
devin-ai-integration[bot] a4c320c
refactor: simplify optional extras per review feedback
devin-ai-integration[bot] 5c8edc3
fix: mark cloud/notification deps as optional, update CI to install i…
devin-ai-integration[bot] a5f43df
fix: keep cloud/notification deps as required for Phase 1 backwards c…
devin-ai-integration[bot] 870175a
feat: add empty extras markers for cloud/notification integrations (P…
devin-ai-integration[bot] cbdcace
feat: make slack_sdk imports lazy to support manual dependency exclus…
devin-ai-integration[bot] 55ec667
ci: install s3 and slack extras in CI to verify they work
devin-ai-integration[bot] 8d50591
ci: install all integration extras (s3, gcs, azure, slack, teams) in CI
devin-ai-integration[bot] fa0c118
ci: remove teams extra from CI (not used in workflow)
devin-ai-integration[bot] e3e0678
chore: rename teams extra to msteams
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 has_gcloud catches overly broad Exception, silently swallowing credential errors
The original
has_gcloudonly caughtDefaultCredentialsError("no credentials found"). The new code catchesexcept Exceptionat line 272, which silently swallows legitimate errors likeTransportError,RefreshError, orPermissionErrorduring credential loading. When a user has configured GCS credentials but encounters a transient or fixable credential issue,has_gcloudwill returnFalseinstead of propagating the error, causing GCS uploads to be silently skipped. The user will get no indication that their credential configuration is broken — the system will just behave as if GCS isn't configured.Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good observation about the broad
except Exception. The original code caught onlyDefaultCredentialsError, but we broadened it to avoid importing the exception class at the top level. Adding alogger.debughere would be a reasonable improvement to avoid silently swallowing credential errors — will defer to the maintainer on whether to include that in this PR or handle separately.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just making sure - we are no longer shadowing exceptions we didn't before? I prefer not to change behavior that we don't have to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch — the original code only caught
DefaultCredentialsError, so theexcept Exceptionbroadens the behavior. I'll narrow it back to catchDefaultCredentialsErrorspecifically (with anImportErrorguard for whengoogle.authitself is missing). This way we don't change existing behavior.