Fix timeout in emscripten_semaphore_wait_acquire#26458
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Mar 18, 2026
Merged
Fix timeout in emscripten_semaphore_wait_acquire#26458sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
force-pushed
the
fix_emscripten_semaphore
branch
3 times, most recently
from
d7df884 to
a14cbf7
Compare
dschuff
approved these changes
Mar 16, 2026
juj
reviewed
Mar 16, 2026
sbc100
force-pushed
the
fix_emscripten_semaphore
branch
from
a14cbf7 to
3e2d021
Compare
This fixes the TODO in this function which meant that the timeout was not correctly honored in the case of multiple wakeups. The code here is basically the same as the existing code in `emscripten_lock_wait_acquire` just above.
sbc100
force-pushed
the
fix_emscripten_semaphore
branch
from
3e2d021 to
b47e8b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the TODO in this function which meant that the timeout was not correctly honored in the case of multiple wakeups.
The code here is basically the same as the existing code in
emscripten_lock_wait_acquirejust above.I also added a new test for
emscripten_lock_wait_acquireeven though the test doesn't specifically test for the TODO issue being addresses in this change (that would require a more complex test that involves generating spurious wakeups).