[Docs] migrate sphinx theme to shibuya#27035
Conversation
e704197 to
a6a85a4
Compare
sbc100
left a comment
There was a problem hiding this comment.
Nice! Thanks for working on this.
I wonder if we can get a preview of what this looks like so we can take a look before landing this.
I believe this Pull request previews is what you're looking for. |
Is that easy to setup? IIUC we don't currently use readthedocs.com at all today. |
|
Not sure because I haven't tried it yet. |
|
I can try downloading this patch and take a look locally. |
|
Just a flaky test sadly. Re-running. |
|
I just added the following new configuration for showing "Edit this page" on the sidebar: html_context = {
# Edit this page
"source_type": "github",
"source_user": "emscripten-core",
"source_repo": "emscripten",
"source_version": "main",
"source_docs_path": "/site/source/",
}Preview:
|
|
Nice! Thanks again for working on this. |
|
Uploaded a copy of the pre-built site. There are a few things I'm not sure about still:
|
Sure. We can disable it by: html_theme_options = {
"show_ai_links": False,
} |
This is the latest v7 release. Split out from emscripten-core#27035
This is the latest v7 release. Split out from #27035
|
I landed on the version bump separately BTW: #27042 |
|
Looks nice! One note, maybe we can use the light theme by default? That would be less of a change compared to before, which makes it more familiar for users. |
That shouldn't be a problem because the default theme is "auto". Therefore, it will display light/dark themes based on the theme users are using. |
Just my personal opinion: I feel that keeping a forum-style discussion board that supports Markdown syntax is required. As for the Discord link, I suggest we could use the html_theme_options = {
"discord_url": "https://discord.gg/53u3EKq",
} |
- Remove `emscripten_sphinx_rtd_theme` - Pin `sphinx-design==0.6.1`, `shibuya==2026.5.19` - Refactor home page with `sphinx-design` - Internationalize strings in `conf.py` file - Add edit this page to sidebar - Use `:layout: landing` for front page
|
I'd like to another interactive look first. I'll upload the zip file when I do. |






emscripten_sphinx_rtd_themesphinx-design==0.6.1,shibuya==2026.5.19sphinx-designconf.pyfile:layout: landingfor front page