-
Notifications
You must be signed in to change notification settings - Fork 648
feat(securitypolicy): add MergeType support for policy merging #7918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rajatvig
wants to merge
12
commits into
envoyproxy:main
Choose a base branch
from
rajatvig:feat/security-policy-merge
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,144
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Add MergeType field to SecurityPolicy to enable policy merging similar to BackendTrafficPolicy. This allows route-level policies to merge with parent Gateway/Listener policies rather than completely overriding them. Fixes envoyproxy#6734 Signed-off-by: Rajat Vig <[email protected]>
95821a7 to
c8b4bdc
Compare
Signed-off-by: Rajat Vig <[email protected]>
Signed-off-by: Rajat Vig <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7918 +/- ##
==========================================
- Coverage 72.86% 72.82% -0.04%
==========================================
Files 237 237
Lines 35536 35642 +106
==========================================
+ Hits 25894 25957 +63
- Misses 7799 7841 +42
- Partials 1843 1844 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Rajat Vig <[email protected]>
Signed-off-by: Rajat Vig <[email protected]>
Signed-off-by: Rajat Vig <[email protected]>
…y-merge Signed-off-by: Rajat Vig <[email protected]>
Signed-off-by: Rajat Vig <[email protected]>
Signed-off-by: Rajat Vig <[email protected]>
Signed-off-by: Rajat Vig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MergeType field to SecurityPolicy to enable policy merging similar
to BackendTrafficPolicy. This allows route-level policies to merge with
parent Gateway/Listener policies rather than completely overriding them.
Fixes #6734