-
Notifications
You must be signed in to change notification settings - Fork 647
fix: extproc is discarded with failOpen is enabled for wasm #7956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
5be38b4 to
1bbc1c9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7956 +/- ##
==========================================
+ Coverage 72.75% 72.79% +0.03%
==========================================
Files 235 235
Lines 35380 35384 +4
==========================================
+ Hits 25742 25758 +16
+ Misses 7800 7791 -9
+ Partials 1838 1835 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5e6d949 to
aaf85d2
Compare
| name: httproute/default/httproute-2/rule/0/backend/0 | ||
| protocol: HTTP | ||
| weight: 1 | ||
| envoyExtensions: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this empty field, internal/gatewayapi/envoyextensionpolicy.go uses nil to decide whether a policy should be overridden or not.
gateway/internal/gatewayapi/envoyextensionpolicy.go
Lines 534 to 536 in 09b6456
| if r.EnvoyExtensions != nil { | |
| continue | |
| } |
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
|
/retest |
fix #7886