Skip to content

Conversation

@zhaohuabing
Copy link
Member

fix #7886

@zhaohuabing zhaohuabing requested a review from a team as a code owner January 14, 2026 13:22
@zhaohuabing zhaohuabing marked this pull request as draft January 14, 2026 13:22
@netlify
Copy link

netlify bot commented Jan 14, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit c5a9861
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/696886a2051ff700082846cb
😎 Deploy Preview https://deploy-preview-7956--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@zhaohuabing zhaohuabing removed the request for review from a team January 14, 2026 13:22
@zhaohuabing zhaohuabing force-pushed the fix-7886 branch 3 times, most recently from 5be38b4 to 1bbc1c9 Compare January 14, 2026 13:27
@zhaohuabing zhaohuabing added this to the v1.7.0-rc.1 Release milestone Jan 14, 2026
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.79%. Comparing base (44676b8) to head (c5a9861).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/envoyextensionpolicy.go 93.75% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7956      +/-   ##
==========================================
+ Coverage   72.75%   72.79%   +0.03%     
==========================================
  Files         235      235              
  Lines       35380    35384       +4     
==========================================
+ Hits        25742    25758      +16     
+ Misses       7800     7791       -9     
+ Partials     1838     1835       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

name: httproute/default/httproute-2/rule/0/backend/0
protocol: HTTP
weight: 1
envoyExtensions: {}
Copy link
Member Author

@zhaohuabing zhaohuabing Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this empty field, internal/gatewayapi/envoyextensionpolicy.go uses nil to decide whether a policy should be overridden or not.

if r.EnvoyExtensions != nil {
continue
}

@zhaohuabing zhaohuabing requested a review from a team January 15, 2026 04:26
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
@arkodg arkodg requested review from a team January 17, 2026 19:42
@zirain
Copy link
Member

zirain commented Jan 18, 2026

/retest

@zhaohuabing zhaohuabing merged commit b28b77c into envoyproxy:main Jan 19, 2026
57 of 59 checks passed
@zhaohuabing zhaohuabing deleted the fix-7886 branch January 19, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WASM OCI image fetch failure with failOpen:true still invalidates entire EnvoyExtensionPolicy including ExtProc

3 participants