Skip to content

Conversation

@andreik-n2
Copy link

@andreik-n2 andreik-n2 commented Jan 15, 2026

What type of PR is this?

fix: ignore initial_fetch_timeout in bootstrap validation to allow modifying this parameter. Set initial_fetch_timeout to 0s by default.

What this PR does / why we need it: This PR updates the bootstrap validation logic to ignore the initial_fetch_timeout field within cds_config and lds_config during comparison. Also this PR sets default initial_fetch_timeout to 0s in the bootstrap config.

Which issue(s) this PR fixes:

Fixes #5574
Release Notes: Yes

@andreik-n2 andreik-n2 requested a review from a team as a code owner January 15, 2026 07:37
@netlify
Copy link

netlify bot commented Jan 15, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 8e7dd07
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/696cfb46760b3e0008fa2677
😎 Deploy Preview https://deploy-preview-7962--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@zirain
Copy link
Member

zirain commented Jan 15, 2026

please add a release notes.

@zirain
Copy link
Member

zirain commented Jan 15, 2026

@andreik-n2 please fix the conflict.

@arkodg
Copy link
Contributor

arkodg commented Jan 16, 2026

@andreik-n2 can we default to 0 ?

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.83%. Comparing base (5028ac5) to head (8e7dd07).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7962      +/-   ##
==========================================
+ Coverage   72.81%   72.83%   +0.01%     
==========================================
  Files         237      237              
  Lines       35475    35506      +31     
==========================================
+ Hits        25832    25861      +29     
- Misses       7803     7805       +2     
  Partials     1840     1840              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain
Copy link
Member

zirain commented Jan 16, 2026

@andreik-n2 can we default to 0 ?

I don't think this PR change the default value from 15s to 0s, it make it patched.
do you want to introduce a change?

@andreik-n2
Copy link
Author

andreik-n2 commented Jan 16, 2026

@andreik-n2 can we default to 0 ?

Hi @arkodg , are you sure you want set default to 0? I read that it could lead to having envoy proxy in not ready state indefinitely. Is it something you considered?

@arkodg
Copy link
Contributor

arkodg commented Jan 17, 2026

@andreik-n2 can we default to 0 ?

Hi @arkodg , are you sure you want set default to 0? I read that it could lead to having envoy proxy in not ready state indefinitely. Is it something you considered?

yeah its better to fail hard for this case that configure partial config

@arkodg
Copy link
Contributor

arkodg commented Jan 17, 2026

ptal @envoyproxy/gateway-maintainers

@arkodg arkodg added this to the v1.7.0-rc.1 Release milestone Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Determine xDS initial_fetch_timeout value

3 participants