etcdctl: refactor global flags management and simplify command initialization#21230
etcdctl: refactor global flags management and simplify command initialization#21230hwdef wants to merge 1 commit intoetcd-io:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hwdef The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
07f00f6 to
d2f4172
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files
... and 53 files with indirect coverage changes @@ Coverage Diff @@
## main #21230 +/- ##
==========================================
- Coverage 68.45% 68.39% -0.06%
==========================================
Files 429 428 -1
Lines 35288 35292 +4
==========================================
- Hits 24156 24139 -17
- Misses 9746 9754 +8
- Partials 1386 1399 +13 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@siyuanfoundation Thanks for your replay. I have deleted the unnecessary code. |
|
Overall I think the PR looks good. And not using |
…lization Signed-off-by: hwdef <hwdefcom@outlook.com>
e225d89 to
fc8bef4
Compare
|
Thank you for your reply. I have already squashed the commits. |
This PR is a part of: #20270
It prepares for subsequent unit testing.